From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: schmitz@opal.biophys.uni-duesseldorf.de,
linux-fbdev-devel@lists.sourceforge.net,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 6/6] fbdev: c2p - Rename c2p to c2p_planar and correct indentation
Date: Mon, 22 Dec 2008 15:23:59 -0800 [thread overview]
Message-ID: <20081222152359.1e9b2143.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081221150123.327017854@mail.of.borg>
On Sun, 21 Dec 2008 16:01:05 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> + /*
> + * Store a full block of planar data after c2p conversion
> + */
> +
> +static inline void store_planar(void *dst, u32 dst_inc, u32 bpp, u32 d[8])
> +{
> + int i;
> +
> + for (i = 0; i < bpp; i++, dst += dst_inc)
> + *(u32 *)dst = d[perm_c2p_32x8[i]];
> +}
> +
> +
> + /*
> + * Store a partial block of planar data after c2p conversion
> + */
> +
> +static inline void store_planar_masked(void *dst, u32 dst_inc, u32 bpp,
> + u32 d[8], u32 mask)
> +{
> + int i;
> +
> + for (i = 0; i < bpp; i++, dst += dst_inc)
> + *(u32 *)dst = comp(d[perm_c2p_32x8[i]], *(u32 *)dst, mask);
> +}
Why not just make the first arg of these (too large to be inlined)
functions have type u32*, then do away with the casts?
next prev parent reply other threads:[~2008-12-22 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 15:00 [patch 0/6] [patch 0/6] Atari frame buffer fixes Geert Uytterhoeven
2008-12-21 15:01 ` [patch 1/6] fbdev: atafb - Fix line length handling Geert Uytterhoeven
2008-12-21 15:01 ` [patch 2/6] fbdev: atafb - Fix 16 bpp console Geert Uytterhoeven
2008-12-21 15:01 ` [patch 3/6] fbdev: c2p - Cleanups Geert Uytterhoeven
2008-12-22 23:22 ` Andrew Morton
2008-12-23 8:13 ` Geert Uytterhoeven
2008-12-21 15:01 ` [patch 4/6] fbdev: c2p - Extract common c2p core to c2p_core.h Geert Uytterhoeven
2008-12-21 15:01 ` [patch 5/6] fbdev: c2p/atafb - Add support for Atari interleaved bitplanes Geert Uytterhoeven
2008-12-21 15:01 ` [patch 6/6] fbdev: c2p - Rename c2p to c2p_planar and correct indentation Geert Uytterhoeven
2008-12-22 23:23 ` Andrew Morton [this message]
2008-12-23 8:02 ` Geert Uytterhoeven
2008-12-22 23:24 ` [patch 0/6] [patch 0/6] Atari frame buffer fixes Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222152359.1e9b2143.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@opal.biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).