linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yauhen Kharuzhy <jekhor@gmail.com>
To: Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: "linux-fbdev-devel@lists.sourceforge.net"
	<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [jekhor@gmail.com: Metronome specifications]
Date: Wed, 31 Dec 2008 14:59:36 +0200	[thread overview]
Message-ID: <20081231125936.GA18373@jeknote.loshitsa1.net> (raw)
In-Reply-To: <20081231121659.GA1761@jeknote.loshitsa1.net>


And another question: why IRQF_TRIGGER_FALLING is used in IRQ
configuration? As I understood, RDY signal is active with high level,
and using of IRQF_TRIGGER_RISING will be reasonable.

From am200epd.c:

static int am200_setup_irq(struct fb_info *info)
{
	int ret;

	ret = request_irq(IRQ_GPIO(RDY_GPIO_PIN), am200_handle_irq,
				IRQF_DISABLED|IRQF_TRIGGER_FALLING,
				"AM200", info->par);
	if (ret)
		dev_err(&am200_device->dev, "request_irq failed: %d\n", ret);

	return ret;
}

static irqreturn_t am200_handle_irq(int irq, void *dev_id)
{
	struct metronomefb_par *par = dev_id;

	wake_up_interruptible(&par->waitq);
	return IRQ_HANDLED;
}

static int am200_wait_event(struct metronomefb_par *par)
{
	return wait_event_timeout(par->waitq, gpio_get_value(RDY_GPIO_PIN), HZ);
}



-- 
Yauhen Kharuzhy		jekhor _at_ gmail.com
			JID: jek@jabber.ru

A: No
Q: Should I quote below my post?

------------------------------------------------------------------------------

  reply	other threads:[~2008-12-31 12:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081230154614.GA30164@jeknote.loshitsa1.net>
2008-12-30 15:56 ` [jekhor@gmail.com: Metronome specifications] Jaya Kumar
2008-12-31 12:16   ` Yauhen Kharuzhy
2008-12-31 12:59     ` Yauhen Kharuzhy [this message]
2008-12-31 14:16       ` Yauhen Kharuzhy
2008-12-31 20:42         ` Jaya Kumar
2008-12-31 20:38     ` Jaya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081231125936.GA18373@jeknote.loshitsa1.net \
    --to=jekhor@gmail.com \
    --cc=jayakumar.lkml@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).