linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hans J. Koch" <hjk@linutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Dan Williams <dan.j.williams@intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers
Date: Tue, 6 Jan 2009 14:20:25 +0100	[thread overview]
Message-ID: <20090106132025.GB3057@local> (raw)
In-Reply-To: <20090106101929.GD18861@pengutronix.de>

On Tue, Jan 06, 2009 at 11:19:29AM +0100, Sascha Hauer wrote:
> On Tue, Jan 06, 2009 at 10:51:37AM +0100, Guennadi Liakhovetski wrote:
> > Hi Sascha
> > 
> > On Tue, 6 Jan 2009, Sascha Hauer wrote:
> > 
> > > Hi Guennadi,
> > > 
> > > On Fri, Dec 26, 2008 at 06:11:13PM +0100, Guennadi Liakhovetski wrote:
> > > > Hi,
> > > > 
> > > > This is version 6 of dmaengine and framebuffer drivers for i.MX31.
> > > > 
> > > > Changes since version 5: as requested by Sascha Hauer switched to dynamic 
> > > > IPU IRQ mapping.
> > > 
> > > I tried to express that it's really odd that you demux your _internal_
> > > interrupts as chained handlers.
> > 
> > Your last comment was:
> > 
> > > Preferably a way which does not involve introducing 100+ unused
> > > interrupts.
> > 
> > which I have done. Now we're back to demux / not demux...
> 
> Can *please* anybody else say something to this issue to calm this down?
> To make it easier for you please sign:
> 
> [ ] The code is fine the way it is. Sascha go home.
> [ ] The code could be better, but hey, it works and the world is not
>     perfect.
> [x] No, we shouldn't abuse chained interrupts for internal irq
>     dispatching.

Definitly the last one, for the reasons you gave in your last mail.
Using chained irqs is not the natural thing to do here.

Thanks,
Hans

  reply	other threads:[~2009-01-06 13:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 17:11 [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 1/4 v6] dmaengine: add async_tx_clear_ack() macro Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 2/4 v6] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 3/4 v6] i.MX31: framebuffer driver Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 4/4 v6] i.MX31: platform bindings and initialisation for IPU and framebuffer drivers Guennadi Liakhovetski
2009-01-05 19:43 ` [PATCH 0/4 v6] i.MX31: dmaengine " Dan Williams
2009-01-05 21:02   ` Guennadi Liakhovetski
2009-01-05 21:35     ` Dan Williams
2009-01-16 10:09   ` Guennadi Liakhovetski
2009-01-16 17:39     ` Dan Williams
2009-01-06  9:04 ` Sascha Hauer
2009-01-06  9:51   ` Guennadi Liakhovetski
2009-01-06 10:19     ` Sascha Hauer
2009-01-06 13:20       ` Hans J. Koch [this message]
2009-01-08 11:15         ` [PATCH 2/4 v7] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2009-01-08 10:50 ` [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106132025.GB3057@local \
    --to=hjk@linutronix.de \
    --cc=adaplas@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).