linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-omap@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 02/12] DSS: Display subsystem for OMAP2/3
Date: Mon, 12 Jan 2009 15:02:00 +0200	[thread overview]
Message-ID: <20090112130158.GF9373@atomide.com> (raw)
In-Reply-To: <20090112114732.1003.6162.stgit@tubuntu>

* Tomi Valkeinen <tomi.valkeinen@nokia.com> [090112 14:37]:
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> ---
> 
>  arch/arm/plat-omap/Kconfig                |    2 
>  arch/arm/plat-omap/Makefile               |    2 
>  arch/arm/plat-omap/dss/Kconfig            |   71 +
>  arch/arm/plat-omap/dss/Makefile           |    6 
>  arch/arm/plat-omap/dss/dispc.c            | 2113 +++++++++++++++++++++++++++++
>  arch/arm/plat-omap/dss/display.c          |  787 +++++++++++
>  arch/arm/plat-omap/dss/dpi.c              |  344 +++++
>  arch/arm/plat-omap/dss/dss.c              |  774 +++++++++++
>  arch/arm/plat-omap/dss/dss.h              |  274 ++++
>  arch/arm/plat-omap/dss/sdi.c              |  174 ++
>  arch/arm/plat-omap/include/mach/display.h |  462 ++++++
>  11 files changed, 5009 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/plat-omap/dss/Kconfig
>  create mode 100644 arch/arm/plat-omap/dss/Makefile
>  create mode 100644 arch/arm/plat-omap/dss/dispc.c
>  create mode 100644 arch/arm/plat-omap/dss/display.c
>  create mode 100644 arch/arm/plat-omap/dss/dpi.c
>  create mode 100644 arch/arm/plat-omap/dss/dss.c
>  create mode 100644 arch/arm/plat-omap/dss/dss.h
>  create mode 100644 arch/arm/plat-omap/dss/sdi.c
>  create mode 100644 arch/arm/plat-omap/include/mach/display.h

Sorry, no subdirectories allowed under arch/arm/*omap*. Please move
these to live under drivers/video somewhere.

Also, you should not need to use cpu_is_omapxxxx() macros under
drivers, please separate out the low-level init to happen under
arch/arm/*omap* and pass the necessary things to the driver in
the platform_data. See how usb and mmc are doing it for example.

Regards,

Tony

  reply	other threads:[~2009-01-12 13:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 11:47 [PATCH 00/12] DSS: Series description Tomi Valkeinen
2009-01-12 11:47 ` [PATCH 01/12] DSS: Documentation for DSS2 Tomi Valkeinen
2009-01-12 11:47 ` [PATCH 02/12] DSS: Display subsystem for OMAP2/3 Tomi Valkeinen
2009-01-12 13:02   ` Tony Lindgren [this message]
2009-01-12 13:06     ` [Linux-fbdev-devel] " Shah, Hardik
2009-01-12 13:17       ` Tony Lindgren
2009-01-12 11:47 ` [PATCH 03/12] DSS: RFBI support Tomi Valkeinen
2009-01-12 13:03   ` Tony Lindgren
2009-01-12 11:47 ` [PATCH 04/12] DSS: VENC support Tomi Valkeinen
2009-01-12 11:47 ` [PATCH 05/12] DSS: DSI support Tomi Valkeinen
2009-01-12 11:47 ` [PATCH 06/12] DSS: OMAPFB: fb driver for new display subsystem Tomi Valkeinen
2009-01-12 11:48 ` [PATCH 07/12] DSS: Add generic DVI panel Tomi Valkeinen
2009-01-12 11:48 ` [PATCH 08/12] DSS: support for Beagle Board Tomi Valkeinen
2009-01-13 11:14   ` David Brownell
2009-01-13 11:37     ` Tomi Valkeinen
2009-01-12 11:48 ` [PATCH 09/12] DSS: Sharp LS037V7DW01 LCD Panel driver Tomi Valkeinen
2009-01-12 11:48 ` [PATCH 10/12] DSS: Support for OMAP3 SDP board Tomi Valkeinen
2009-01-13 11:15   ` David Brownell
2009-01-12 11:48 ` [PATCH 11/12] DSS: Support for OMAP3 EVM board Tomi Valkeinen
2009-01-12 11:48 ` [PATCH 12/12] DSS: Hacked N810 support Tomi Valkeinen
2009-01-12 13:44 ` [PATCH 00/12] DSS: Series description Koen Kooi
2009-01-12 14:52   ` Hiremath, Vaibhav
2009-01-12 15:39     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112130158.GF9373@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).