From: "Ville Syrjälä" <syrjala@sci.fi>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 1/2] atyfb: fix CONFIG_ namespace violations
Date: Tue, 3 Feb 2009 13:06:31 +0200 [thread overview]
Message-ID: <20090203110631.GB22401@sci.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0902030907350.15898@anakin>
On Tue, Feb 03, 2009 at 09:09:38AM +0100, Geert Uytterhoeven wrote:
> On Mon, 2 Feb 2009, Randy Dunlap wrote:
> > --- linux-2.6.29-rc3-git3.orig/drivers/video/aty/atyfb_base.c
> > +++ linux-2.6.29-rc3-git3/drivers/video/aty/atyfb_base.c
> > @@ -135,7 +135,7 @@
> > #if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \
> > defined (CONFIG_FB_ATY_GENERIC_LCD) || defined(CONFIG_FB_ATY_BACKLIGHT)
> > static const u32 lt_lcd_regs[] = {
> > - CONFIG_PANEL_LG,
> > + CNFG_PANEL_LG,
>
> These were the official names as used in the ATI docs. After these changes, you
> can no longer easily grep for them.
>
> Perhaps it's better to prefix everything with ATI_? yes, I know it's more work
> (for the writer), but we want to optimize for the reader, right?
That would be my preference as well.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2009-02-03 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901310909.n0V99XIZ021497@imap1.linux-foundation.org>
[not found] ` <4984AC40.8030708@oracle.com>
[not found] ` <20090131121008.eb7f5ddd.akpm@linux-foundation.org>
2009-02-02 23:00 ` [PATCH 1/2] atyfb: fix CONFIG_ namespace violations Randy Dunlap
2009-02-03 8:09 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-02-03 11:06 ` Ville Syrjälä [this message]
2009-02-03 22:23 ` Randy Dunlap
[not found] ` <4988C3E6.5010508@oracle.com>
2009-02-03 23:58 ` [Linux-fbdev-devel] " Ville Syrjälä
2009-02-02 23:00 ` [PATCH 2/2] atyfb: fix header file trailing whitespace Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203110631.GB22401@sci.fi \
--to=syrjala@sci.fi \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).