From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: geert@linux-m68k.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] cirrusfb: convert printks to dev_foo
Date: Tue, 3 Feb 2009 13:50:18 -0800 [thread overview]
Message-ID: <20090203135018.03d5d59e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090202195659.67b12917.krzysztof.h1@poczta.fm>
Thanks.
On Mon, 2 Feb 2009 19:56:59 +0100
Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> Author: Krzysztof Helt <krzysztof.h1@wp.pl>
This isn't needed - it's a git thing. For email we use From: lines.
> Convert all printks to dev_dbg, dev_info
> or dev_err. Kill some excessive debug
> information and code in the process.
I added your Signed-off-by: to this.
> diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
> index 30684fb..21302d1 100644
> --- a/drivers/video/cirrusfb.c
> +++ b/drivers/video/cirrusfb.c
I got a couple of rejects against current mainline, easily fixed.
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
prev parent reply other threads:[~2009-02-03 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 18:56 [PATCH] cirrusfb: convert printks to dev_foo Krzysztof Helt
2009-02-03 21:50 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203135018.03d5d59e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).