linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andrey Borzenkov <arvidjaar@mail.ru>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"Antonino A. Daplas" <adaplas@gmail.com>,
	linux-fbdev-devel@lists.sourceforge.net,
	linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Dave Jones <davej@redhat.com>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH -mmotm] fbmem: fix fb_info->lock and mm->mmap_sem circular locking dependency
Date: Thu, 5 Feb 2009 02:49:25 +0100	[thread overview]
Message-ID: <200902050249.27244.rjw@sisk.pl> (raw)
In-Reply-To: <200902050058.31680.rjw@sisk.pl>

On Thursday 05 February 2009, Rafael J. Wysocki wrote:
> On Wednesday 04 February 2009, Andrea Righi wrote:
> > Fix this circular locking dependencies in the frame buffer console
> > driver pushing down the mutex fb_info->lock.
> > 
> > Circular locking dependecies occur calling the blocking
> > fb_notifier_call_chain() with fb_info->lock held. Notifier callbacks can
> > try to acquire mm->mmap_sem, while fb_mmap() acquires the locks in the
> > reverse order mm->mmap_sem => fb_info->lock.
> 
> Does this fix a Bugzilla bug?  If so, then which one?

Never mind, found it.

Thanks,
Rafael

  reply	other threads:[~2009-02-05  1:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 18:37 [2.6.29-rc2] fb_mmap: circular locking dependency on hibernation Andrey Borzenkov
2009-01-29  9:10 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-01-29 10:03   ` Andrea Righi
2009-01-30  4:15   ` Andrey Borzenkov
2009-01-30 10:23     ` Andrea Righi
2009-01-31 15:53       ` Andrea Righi
2009-01-31 16:05         ` Andrey Borzenkov
2009-01-31 17:09     ` Andrea Righi
2009-01-31 17:44       ` Geert Uytterhoeven
2009-01-31 18:11         ` Andrea Righi
2009-02-01  7:15       ` Andrey Borzenkov
2009-02-01 22:50         ` Andrea Righi
2009-02-02 17:36           ` Andrey Borzenkov
2009-02-03 10:09             ` Andrea Righi
2009-02-04  8:19               ` Andrey Borzenkov
2009-02-04 21:46               ` [PATCH -mmotm] fbmem: fix fb_info->lock and mm->mmap_sem circular locking dependency Andrea Righi
2009-02-04 23:58                 ` Rafael J. Wysocki
2009-02-05  1:49                   ` Rafael J. Wysocki [this message]
2009-03-22 14:48                 ` Andrey Borzenkov
2009-03-22 17:57                   ` Rafael J. Wysocki
2009-03-22 21:52                     ` Andrew Morton
2009-04-06 18:47                       ` commit 66c1ca breaks fbdev mode switching Krzysztof Helt
2009-04-06 21:45                         ` Andrea Righi
2009-04-07  9:17                           ` Geert Uytterhoeven
2009-04-07  9:54                             ` Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902050249.27244.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arvidjaar@mail.ru \
    --cc=davej@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=hannes@cmpxchg.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=righi.andrea@gmail.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).