[PATCH 3/15] tridentfb: fix memory leaks in removal path

[PATCH 3/15] tridentfb: fix memory leaks in removal path

[Andres Salomon]

We were leaking the cmap memory.

Signed-off-by: Andres Salomon <dilinger@debian.org>
---
 drivers/video/tridentfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c
index 479b2e7..c5369ba 100644
--- a/drivers/video/tridentfb.c
+++ b/drivers/video/tridentfb.c
@@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
 	release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
 	pci_set_drvdata(dev, NULL);
 	kfree(info->pixmap.addr);
+	fb_dealloc_cmap(&info->cmap);
 	framebuffer_release(info);
 }
 
-- 
1.5.6.5


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com

Re: [PATCH 3/15] tridentfb: fix memory leaks in removal path

[Krzysztof Helt]

On Sat, 7 Feb 2009 12:12:33 -0500
Andres Salomon <dilinger@queued.net> wrote:

> 
> We were leaking the cmap memory.
> 
> Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---


Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>


>  drivers/video/tridentfb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c
> index 479b2e7..c5369ba 100644
> --- a/drivers/video/tridentfb.c
> +++ b/drivers/video/tridentfb.c
> @@ -1563,6 +1563,7 @@ static void __devexit trident_pci_remove(struct pci_dev *dev)
>  	release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
>  	pci_set_drvdata(dev, NULL);
>  	kfree(info->pixmap.addr);
> +	fb_dealloc_cmap(&info->cmap);
>  	framebuffer_release(info);
>  }
>  


----------------------------------------------------------------------
Zostan mistrzem parkowania w Bombaju!
Zagraj >> http://link.interia.pl/f204e 


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com