From: Andres Salomon <dilinger@queued.net>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
j@mx08.poczta.interia.pl,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, adaplas@gmail.com
Subject: Re: [Linux-fbdev-devel] [PATCH 8/15] stifb: check fb_alloc_cmap return value and handle failure properly
Date: Mon, 9 Feb 2009 13:57:21 -0500 [thread overview]
Message-ID: <20090209135721.1db97470@ephemeral> (raw)
In-Reply-To: <20090209180549.cb07d0fb.krzysztof.h1@wp.pl>
On Mon, 9 Feb 2009 18:05:49 +0100
Krzysztof Helt <krzysztof.h1@wp.pl> wrote:
> On Sat, 7 Feb 2009 12:15:06 -0500
> Andres Salomon <dilinger@queued.net> wrote:
>
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
> > ---
>
> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> I feel something is not right with the driver if memory
> region (info->screen_base) is io mapped first then
> reserved with request_mem_region().
>
> Regards,
> Krzysztof
Yeah, I noticed quite a few other bugs while going through cmap brokenness,
and I'm not even done w/ the cmap stuff yet. I figured I'd do one thing at
a time.
Thanks for the Acks!
prev parent reply other threads:[~2009-02-09 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 17:15 [PATCH 8/15] stifb: check fb_alloc_cmap return value and handle failure properly Andres Salomon
2009-02-09 17:05 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-02-09 18:57 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209135721.1db97470@ephemeral \
--to=dilinger@queued.net \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=j@mx08.poczta.interia.pl \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).