From: Andres Salomon <dilinger@queued.net>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, adaplas@gmail.com
Subject: Re: [Linux-fbdev-devel] [PATCH 13/15] amba-clcd: fix cmap memory leaks
Date: Mon, 9 Feb 2009 16:55:40 -0500 [thread overview]
Message-ID: <20090209165540.523c2ce4@ephemeral> (raw)
In-Reply-To: <20090209211614.44459a12.krzysztof.h1@wp.pl>
On Mon, 9 Feb 2009 21:16:14 +0100
Krzysztof Helt <krzysztof.h1@wp.pl> wrote:
> On Sat, 7 Feb 2009 12:18:48 -0500
> Andres Salomon <dilinger@queued.net> wrote:
>
> >
> > - fix cmap leak in removal path
> > - fix cmap leak when register_framebuffer fails
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
> > ---
>
> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> One comment (see below).
>
[...]
> > @@ -485,6 +489,8 @@ static int clcdfb_remove(struct amba_device
> > *dev)
> > clcdfb_disable(fb);
> > unregister_framebuffer(&fb->fb);
> > + if (fb->fb.cmap.len)
> > + fb_dealloc_cmap(&fb->fb.cmap);
>
> Is this if() needed? Is this function called twice (or more) or
> can it be called without the cmap allocated?
It was added as a precaution due to the fb->board->remove callbacks,
but I think I misunderstood the code. So my official answer is "I'm not
sure." :)
>
> > iounmap(fb->regs);
> > clk_put(fb->clk);
> >
> > --
> > 1.5.6.5
> >
prev parent reply other threads:[~2009-02-09 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 17:18 [PATCH 13/15] amba-clcd: fix cmap memory leaks Andres Salomon
2009-02-09 20:16 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-02-09 21:55 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209165540.523c2ce4@ephemeral \
--to=dilinger@queued.net \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).