From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: arthur.marsh@internode.on.net, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] cirrusfb: do not calculate line length twice
Date: Thu, 19 Feb 2009 16:27:54 -0800 [thread overview]
Message-ID: <20090219162754.d175d6c0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090214185045.c288650e.krzysztof.h1@poczta.fm>
On Sat, 14 Feb 2009 18:50:45 +0100
Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> A line length is calculated twice: first in
> the cirrusfb_decode_var() then in
> the cirrusfb_set_par_foo().
>
> Use the first calculated value. A nice side
> effect is that 32bpp mode works now.
Do you get these as well?
drivers/video/cirrusfb.c: In function 'cirrusfb_set_par_foo':
drivers/video/cirrusfb.c:663: warning: 'format' may be used uninitialized in this function
drivers/video/cirrusfb.c:663: warning: 'threshold' may be used uninitialized in this function
drivers/video/cirrusfb.c:663: warning: 'control' may be used uninitialized in this function
they're false positives, but it would be nice to squash them somehow.
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
prev parent reply other threads:[~2009-02-20 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 17:50 [PATCH 1/2] cirrusfb: do not calculate line length twice Krzysztof Helt
2009-02-20 0:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219162754.d175d6c0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arthur.marsh@internode.on.net \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).