From: "Ville Syrjälä" <syrjala@sci.fi>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] atyfb: speed up Mach64 cursor
Date: Sat, 21 Mar 2009 22:01:03 +0200 [thread overview]
Message-ID: <20090321200103.GU10127@sci.fi> (raw)
In-Reply-To: <20090317220443.d8dd67bb.krzysztof.h1@poczta.fm>
On Tue, Mar 17, 2009 at 10:04:43PM +0100, Krzysztof Helt wrote:
> --- a/drivers/video/aty/mach64_cursor.c
> +++ b/drivers/video/aty/mach64_cursor.c
> @@ -77,9 +77,13 @@ static int atyfb_cursor(struct fb_info *info, struct fb_cursor *cursor)
> if (par->asleep)
> return -EPERM;
>
> - /* Hide cursor */
> wait_for_fifo(1, par);
> - aty_st_le32(GEN_TEST_CNTL, aty_ld_le32(GEN_TEST_CNTL, par) & ~HWCURSOR_ENABLE, par);
> + if (cursor->enable)
> + aty_st_le32(GEN_TEST_CNTL, aty_ld_le32(GEN_TEST_CNTL, par)
> + | HWCURSOR_ENABLE, par);
> + else
> + aty_st_le32(GEN_TEST_CNTL, aty_ld_le32(GEN_TEST_CNTL, par)
> + & ~HWCURSOR_ENABLE, par);
It looks like you are now enabling the cursor before the cursor image
is loaded or the cursor is moved to the correct position so the user
could briefly see a corrupted and/or misplaced cursor.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
next prev parent reply other threads:[~2009-03-21 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 21:04 [PATCH] atyfb: speed up Mach64 cursor Krzysztof Helt
2009-03-21 20:01 ` Ville Syrjälä [this message]
2009-03-21 20:50 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090321200103.GU10127@sci.fi \
--to=syrjala@sci.fi \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).