* [PATCH] sisfb: fix color component length for pseudocolor modes
@ 2009-03-30 22:13 Michal Januszewski
2009-04-01 17:05 ` [Linux-fbdev-devel] " Krzysztof Helt
0 siblings, 1 reply; 2+ messages in thread
From: Michal Januszewski @ 2009-03-30 22:13 UTC (permalink / raw)
To: linux-kernel; +Cc: thomas, linux-fbdev-devel
sisfb incorrectly sets the length of the color fields to 6 bits
for PSEUDOCOLOR modes, even though 8 bits are always used per pixel.
Fix this by setting the length to 8.
Signed-off-by: Michal Januszewski <spock@gentoo.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
---
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 346d645..7e17ee9 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
@@ -1129,7 +1129,7 @@ sisfb_bpp_to_var(struct sis_video_info *ivideo, struct fb_var_screeninfo *var)
switch(var->bits_per_pixel) {
case 8:
var->red.offset = var->green.offset = var->blue.offset = 0;
- var->red.length = var->green.length = var->blue.length = 6;
+ var->red.length = var->green.length = var->blue.length = 8;
break;
case 16:
var->red.offset = 11;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Linux-fbdev-devel] [PATCH] sisfb: fix color component length for pseudocolor modes
2009-03-30 22:13 [PATCH] sisfb: fix color component length for pseudocolor modes Michal Januszewski
@ 2009-04-01 17:05 ` Krzysztof Helt
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Helt @ 2009-04-01 17:05 UTC (permalink / raw)
To: spock; +Cc: linux-kernel, thomas, linux-fbdev-devel
On Tue, 31 Mar 2009 00:13:40 +0200
Michal Januszewski <spock@gentoo.org> wrote:
> sisfb incorrectly sets the length of the color fields to 6 bits
> for PSEUDOCOLOR modes, even though 8 bits are always used per pixel.
> Fix this by setting the length to 8.
>
> Signed-off-by: Michal Januszewski <spock@gentoo.org>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> ---
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
----------------------------------------------------------------------
Twoj znajomy gwiazda filmu XXX? Wkrec go! ;)
Kliknij >>> http://link.interia.pl/f20f1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-01 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-30 22:13 [PATCH] sisfb: fix color component length for pseudocolor modes Michal Januszewski
2009-04-01 17:05 ` [Linux-fbdev-devel] " Krzysztof Helt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).