From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] fbdev: move logo externs to header file Date: Fri, 3 Apr 2009 15:45:40 +0200 Message-ID: <20090403134540.GA16066@uranus.ravnborg.org> References: <20090403123143.GA15598@uranus.ravnborg.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Linux Frame Buffer Device Development , Krzysztof Helt , Andrew Morton , James Simmons , Linux Kernel Development On Fri, Apr 03, 2009 at 03:38:37PM +0200, Geert Uytterhoeven wrote: > On Fri, 3 Apr 2009, Sam Ravnborg wrote: > > On Fri, Apr 03, 2009 at 01:45:40PM +0200, Geert Uytterhoeven wrote: > > > Now we have __initconst, we can finally move the external declarations for the > > > various Linux logo structures to . > > > > > > Signed-off-by: Geert Uytterhoeven > > > Acked-By: James Simmons > > > --- > > > James' ack dates back to the previous submission (way to long ago), when the > > > logos were still __initdata, which caused failures on some platforms with some > > > toolchain versions. > > > > > > Note: you have to remove the generated logos, as they're not automatically > > > regenerated if scripts/pnmtologo.c changes. > > > > Something like this to fix that bug? > > Yep, after s/pnmtlogo/pnmtologo/g > (it cannot work as-is, as there's one place where you did spell `pnmtologo' > correctly ;-) > > Acked-by: Geert Uytterhoeven I assume you take the patch - no? Sam