Re: [PATCH] resend: radeon backlight shutoff flashes momentarily

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 01 Apr 2009 02:27:54 -0700 "Robert T. Drury" <rtdrury@earthlink.net> wrote:

> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12845
> 
> Aluminum Powerbook G4 with Radeon 9600:
> 
> The backlight momentarily flashes brightly when turning off.  If the
> backlight is originally dim, the flash is more noticeable.  This momentary
> flash is stressful on the power circuit.
> 
> This patch removes the & ~LVDS_BL_MOD_EN above the first OUTREG to 
> LVDS_GEN_CNTL to eliminate the flash on shutoff, only for powerbook5,3 
> and CHIP_FAMILY_RV350.
> 
> Signed-off-by: Robert Drury <rtdrury@earthlink.net>
> 
> --- linux-2.6.23.9/drivers/video/aty/radeon_backlight.c.orig	2009-03-22 19:04:22.000000000 -0700
> +++ linux-2.6.23.9/drivers/video/aty/radeon_backlight.c	2009-03-22 19:19:09.000000000 -0700
> @@ -101,7 +101,10 @@ static int radeon_bl_update_status(struc
>  		tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
>  		if (rinfo->is_mobility || rinfo->is_IGP)
>  			OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
> -		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
> +		lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK);
> +		if(rinfo->family != CHIP_FAMILY_RV350 
> +			|| !machine_is_compatible("PowerBook5,3"))
> +				lvds_gen_cntl &= ~LVDS_BL_MOD_EN;
>  		lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
>  				  LVDS_BL_MOD_LEVEL_SHIFT);
>  		lvds_gen_cntl |= LVDS_DISPLAY_DIS;

machine_is_compatible() isn't defined on x86 so this breaks the build.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com