From: Andrew Morton <akpm@linux-foundation.org>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: Pavel Roskin <proski@gnu.org>,
"Antonino A. Daplas" <adaplas@gmail.com>,
Andrey Borzenkov <arvidjaar@gmail.com>,
Harvey@smtp1.linux-foundation.org,
Johannes Weiner <hannes@cmpxchg.org>,
Krzysztof Helt <krzysztof.h1@poczta.fm>,
LKML <linux-kernel@vger.kernel.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-pm@lists.linux-foundation.org,
Harrison <harvey.harrison@gmail.com>
Subject: Re: [REGRESSION] commit 66c1ca0: {fbmem: fix fb_info->lock and mm->mmap_sem ...} causes Xfbdev not working
Date: Sat, 11 Apr 2009 11:21:31 -0700 [thread overview]
Message-ID: <20090411112131.cc38dcf0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090411150359.GA8265@linux>
On Sat, 11 Apr 2009 17:04:00 +0200 Andrea Righi <righi.andrea@gmail.com> wrote:
> fbdev: fix info->lock deadlock in fbcon_event_notify()
>
> fb_notifier_call_chain() is called with info->lock held, i.e. in
> do_fb_ioctl() => FBIOPUT_VSCREENINFO => fb_set_var() and the some
> notifier callbacks, like fbcon_event_notify(), try to re-acquire
> info->lock again.
>
> Remove the lock/unlock_fb_info() in all the framebuffer notifier
> callbacks' and be sure to always call fb_notifier_call_chain() with
> info->lock held.
Thanks. So do you think we should proceed with this patch instead of
reverting 66c1ca0?
next prev parent reply other threads:[~2009-04-11 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f17812d70904090436kd03744brca4a4bc4b85bba8@mail.gmail.com>
2009-04-09 12:58 ` [REGRESSION] commit 66c1ca0: {fbmem: fix fb_info->lock and mm->mmap_sem ...} causes Xfbdev not working Andrea Righi
2009-04-10 20:21 ` Krzysztof Helt
2009-04-10 21:16 ` Andrew Morton
2009-04-10 22:05 ` Andrea Righi
2009-04-11 6:04 ` Krzysztof Helt
[not found] ` <49E05C36.9040204@s5r6.in-berlin.de>
2009-04-11 11:08 ` Andrea Righi
2009-04-11 15:04 ` Andrea Righi
[not found] ` <20090411150359.GA8265@linux>
2009-04-11 18:21 ` Andrew Morton [this message]
2009-04-11 19:32 ` Andrea Righi
2009-04-13 23:34 ` Andreas Schwab
[not found] ` <20090417182507.0bd85ccc.krzysztof.h1@poczta.fm>
2009-04-17 22:51 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090411112131.cc38dcf0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Harvey@smtp1.linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=arvidjaar@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hannes@cmpxchg.org \
--cc=harvey.harrison@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=proski@gnu.org \
--cc=righi.andrea@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).