linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <syrjala@sci.fi>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] initialize fb_info->lock mutex in	the framebuffer_alloc()
Date: Mon, 4 May 2009 01:54:02 +0300	[thread overview]
Message-ID: <20090503225402.GA17782@sci.fi> (raw)
In-Reply-To: <20090503233008.bf4b9f57.krzysztof.h1@poczta.fm>

On Sun, May 03, 2009 at 11:30:08PM +0200, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> The fb_info->lock mutex should be initialized inside 
> the framebuffer_alloc() function. Otherwise, someone
> may call a fb layer function which indirectly uses uninitialized 
> mutex.

How can that someone find the fb_info without it being in the
registered_fb[] array?

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf

       reply	other threads:[~2009-05-03 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090503233008.bf4b9f57.krzysztof.h1@poczta.fm>
2009-05-03 22:54 ` Ville Syrjälä [this message]
2009-05-04  6:47 ` [PATCH] initialize fb_info->lock mutex in the framebuffer_alloc() Geert Uytterhoeven
2009-05-04  8:08 krzysztof.h1
2009-05-04  8:50 ` Geert Uytterhoeven
  -- strict thread matches above, loose matches on Subject: below --
2009-05-04  8:23 krzysztof.h1
2009-05-04  9:53 krzysztof.h1
2009-05-04 11:47 krzysztof.h1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090503225402.GA17782@sci.fi \
    --to=syrjala@sci.fi \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).