linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Uytterhoeven <geert@linux-m68k.org>,
	Linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>,
	Geert, Andrea Righi <righi.andrea@gmail.com>
Subject: Re: Locking problem: fb_info->lock and mm->mmap_sem
Date: Sun, 10 May 2009 14:02:44 -0700	[thread overview]
Message-ID: <20090510140244.91749527.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090510203455.2ff347e9.krzysztof.h1@poczta.fm>

On Sun, 10 May 2009 20:34:55 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> I can prepare the patch which contains changes
> equivalent to revert of these fixes.
> 
> This version does not show any problems. 

That sounds like an OK plan to me.  Doing this via separate manual
reversion patches would make things easier to maintain, assuming that
this is a 2.6.31 activity.

It might be that the old bkl-based code was simply buggy, because
lock_kernel() gets secretly unlocked by so many operations.  It doesn't
matter, really.

Restoring the lock_kernel()s would make people sad.  Do you have a plan
to de-BKL the fbdev code via other means?  That wasn't clear from your
email.



------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image 
processing features enabled. http://p.sf.net/sfu/kodak-com

  reply	other threads:[~2009-05-10 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 18:34 Locking problem: fb_info->lock and mm->mmap_sem Krzysztof Helt
2009-05-10 21:02 ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-11  6:46 krzysztof.h1
2009-05-11 23:29 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090510140244.91749527.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=righi.andrea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).