From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to Date: Sun, 10 May 2009 21:08:26 +0200 Message-ID: <20090510190825.GB23659@lst.de> References: <1241791284-11490-1-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-2-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-3-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-4-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-5-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-6-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-7-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-8-git-send-email-Geert.Uytterhoeven@sonycom.com> <1241791284-11490-9-git-send-email-Geert.Uytterhoeven@sonycom.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1241791284-11490-9-git-send-email-Geert.Uytterhoeven@sonycom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Benjamin Herrenschmidt , linux-fbdev-devel@lists.sourceforge.net, Arnd Bergmann , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org On Fri, May 08, 2009 at 04:01:17PM +0200, Geert Uytterhoeven wrote: > +/* Cell page table entries */ > +#define IOPTE_PP_W 0x8000000000000000ul /* protection: write */ > +#define IOPTE_PP_R 0x4000000000000000ul /* protection: read */ > +#define IOPTE_M 0x2000000000000000ul /* coherency required */ > +#define IOPTE_SO_R 0x1000000000000000ul /* ordering: writes */ > +#define IOPTE_SO_RW 0x1800000000000000ul /* ordering: r & w */ > +#define IOPTE_RPN_Mask 0x07fffffffffff000ul /* RPN */ > +#define IOPTE_H 0x0000000000000800ul /* cache hint */ > +#define IOPTE_IOID_Mask 0x00000000000007fful /* ioid */ If this is in a global header it should probably have a CELL_ prefix.