From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>,
linux-arm-kernel@lists.arm.linux.org.uk,
Imre Deak <imre.deak@nokia.com>,
linux-omap@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi
Date: Sat, 16 May 2009 10:06:21 +0100 [thread overview]
Message-ID: <20090516090621.GC15328@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090514202805.GQ5593@atomide.com>
On Thu, May 14, 2009 at 01:28:06PM -0700, Tony Lindgren wrote:
> commit 27db33cfadd3c47c9499def6e71aaf5d2fd51e60
> Author: Tony Lindgren <tony@atomide.com>
> Date: Tue May 12 11:20:03 2009 -0700
>
> ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi, v2
>
> This makes the framebuffer work on omap3.
>
> Also fix the clk_get usage for checkpatch.pl
> "ERROR: do not use assignment in if condition".
>
> Cc: Imre Deak <imre.deak@nokia.com>
> Cc: linux-fbdev-devel@lists.sourceforge.net
> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
This isn't a bug fix - the current code works, although checkpatch will
complain about the assignment in the if condition.
The rest of the patch is just a conversion from the old way of doing
things to the new way, and I don't think is -rc material.
next prev parent reply other threads:[~2009-05-16 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090514174100.12080.9736.stgit@localhost>
2009-05-14 17:49 ` [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi Tony Lindgren
2009-05-14 19:03 ` Krzysztof Helt
2009-05-14 20:28 ` Tony Lindgren
2009-05-16 9:06 ` Russell King - ARM Linux [this message]
2009-05-16 15:25 ` Tony Lindgren
2009-05-16 16:22 ` Russell King - ARM Linux
2009-05-16 18:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090516090621.GC15328@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=imre.deak@nokia.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).