* Re: [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249)
[not found] <20090520142704.0de8aa81.krzysztof.h1@poczta.fm>
@ 2009-05-27 6:15 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2009-05-27 6:15 UTC (permalink / raw)
To: Krzysztof Helt; +Cc: Werner, Linux-fbdev-devel, Lemberg
On Wed, 20 May 2009 14:27:04 +0200 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> Does not allow to accept VESA modes by the "vga=" kernel parameter
> if there is no frame buffer driver compiled-in to handle it.
>
> Bug was reported by Werner Lemberg as kernel bug #13249
> "Intel 945GM: Boot option`vga=0x31a' breaks display of TTYs".
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> ---
>
> Werner, please test it. It should produce a correct display
> with intelfb compiled in (=y) and as a module (=m).
>
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 0048f11..c787357 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1122,7 +1122,7 @@ config FB_INTEL
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> - select FB_BOOT_VESA_SUPPORT
> + select FB_BOOT_VESA_SUPPORT if FB_INTEL = y
> help
> This driver supports the on-board graphics built in to the Intel
> 830M/845G/852GM/855GM/865G/915G/915GM/945G/945GM/965G/965GM chipsets.
> @@ -1460,7 +1460,7 @@ config FB_SIS
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> - select FB_BOOT_VESA_SUPPORT
> + select FB_BOOT_VESA_SUPPORT if FB_SIS = y
> help
> This is the frame buffer device driver for the SiS 300, 315, 330
> and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
I read through http://bugzilla.kernel.org/show_bug.cgi?id=13249 and am
now unsure what to do with this patch?
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249)
@ 2009-05-27 7:41 krzysztof.h1
0 siblings, 0 replies; 3+ messages in thread
From: krzysztof.h1 @ 2009-05-27 7:41 UTC (permalink / raw)
To: Andrew Morton, Krzysztof Helt, Linux-fbdev-devel, Werner Lemberg
Andrew Morton napisa³(a):
> On Wed, 20 May 2009 14:27:04 +0200 Krzysztof Helt >krzysztof.h1@poczta.fm>
> wrote:
>
> > From: Krzysztof Helt >krzysztof.h1@wp.pl>
> >
> > Does not allow to accept VESA modes by the "vga=" kernel parameter
> > if there is no frame buffer driver compiled-in to handle it.
> >
> > Bug was reported by Werner Lemberg as kernel bug #13249
> > "Intel 945GM: Boot option`vga=0x31a' breaks display of TTYs".
> >
> > Signed-off-by: Krzysztof Helt >krzysztof.h1@wp.pl>
> > ---
> >
> > Werner, please test it. It should produce a correct display
> > with intelfb compiled in (=y) and as a module (=m).
> >
> >
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 0048f11..c787357 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -1122,7 +1122,7 @@ config FB_INTEL
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > - select FB_BOOT_VESA_SUPPORT
> > + select FB_BOOT_VESA_SUPPORT if FB_INTEL = y
> > help
> > This driver supports the on-board graphics built in to the Intel
> > 830M/845G/852GM/855GM/865G/915G/915GM/945G/945GM/965G/965GM
> chipsets.
> > @@ -1460,7 +1460,7 @@ config FB_SIS
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > - select FB_BOOT_VESA_SUPPORT
> > + select FB_BOOT_VESA_SUPPORT if FB_SIS = y
> > help
> > This is the frame buffer device driver for the SiS 300, 315, 330
> > and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
>
> I read through http://bugzilla.kernel.org/show_bug.cgi?id=13249 and am
> now unsure what to do with this patch?
>
>
Drop it.
I think I know why my laptop uses PIPE_B but both pipes are active. The pipes are connected
to so called planes and driver must check which plane is enabled also.
Otherwise, when both pipes are enabled the driver doesn't know which one is used.
Finally, I found the documentation for i845.
Kind regards,
Krzysztof
----------------------------------------------------------------------
Kup wlasne mieszkanie za 33 tys. zl.
Sprawdz >>> http://link.interia.pl/f21a3
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249)
@ 2009-06-18 21:13 Krzysztof Helt
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Helt @ 2009-06-18 21:13 UTC (permalink / raw)
To: Linux-fbdev-devel; +Cc: Andrew Morton, Werner Lemberg
From: Krzysztof Helt <krzysztof.h1@wp.pl>
Does not allow to accept VESA modes by the "vga=" kernel parameter
if there is no frame buffer driver compiled-in to handle it.
Bug was reported by Werner Lemberg as kernel bug #13249
"Intel 945GM: Boot option`vga=0x31a' breaks display of TTYs".
Also, there is a comment added to the Kconfig description
after Werner Lemberg's suggestion
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
CC: Werner Lemberg
---
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 932ffdb..d6d65ef 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1122,12 +1122,14 @@ config FB_INTEL
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT
+ select FB_BOOT_VESA_SUPPORT if FB_INTEL = y
help
This driver supports the on-board graphics built in to the Intel
830M/845G/852GM/855GM/865G/915G/915GM/945G/945GM/965G/965GM chipsets.
Say Y if you have and plan to use such a board.
+ To make FB_INTELFB=Y work you need to say AGP_INTEL=y too.
+
To compile this driver as a module, choose M here: the
module will be called intelfb.
@@ -1460,7 +1462,7 @@ config FB_SIS
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_BOOT_VESA_SUPPORT
+ select FB_BOOT_VESA_SUPPORT if FB_SIS = y
help
This is the frame buffer device driver for the SiS 300, 315, 330
and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
----------------------------------------------------------------------
Masz juz dosc wysokich rachunkow? Wygraj nowa mozliwosc komunikacji!
Sprawdz >>> http://link.interia.pl/f21d2
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-18 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090520142704.0de8aa81.krzysztof.h1@poczta.fm>
2009-05-27 6:15 ` [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249) Andrew Morton
2009-05-27 7:41 krzysztof.h1
-- strict thread matches above, loose matches on Subject: below --
2009-06-18 21:13 Krzysztof Helt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).