From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [Linux-fbdev-devel] [PATCH 08/20] omapfb: Add support for the OMAP3 EVM LCD Date: Tue, 16 Jun 2009 13:54:54 +0300 Message-ID: <20090616105454.GE32105@localhost> References: <1244137965-8937-1-git-send-email-imre.deak@nokia.com> <833ed44e61e3d4093eb27b55b97252967e042d41.1244131952.git.imre.deak@nokia.com> <5ba715a9dbc88b8c3a8225bc1cfdabd3faffe00f.1244131952.git.imre.deak@nokia.com> <646692ce09a12e1a8a2d4072097b4d440b7de5d5.1244131952.git.imre.deak@nokia.com> <9139035cc12b22600135677cd5d3096c1dcd286d.1244131952.git.imre.deak@nokia.com> <20090614233318.e397a907.krzysztof.h1@poczta.fm> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20090614233318.e397a907.krzysztof.h1@poczta.fm> Sender: linux-omap-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ext Krzysztof Helt Cc: Antonino Daplas , "linux-fbdev-devel@lists.sourceforge.net" , Tony Lindgren , "Valkeinen Tomi (Nokia-D/Helsinki)" , "linux-omap@vger.kernel.org" , Steve Sakoman On Sun, Jun 14, 2009 at 11:33:18PM +0200, ext Krzysztof Helt wrote: > On Thu, 4 Jun 2009 20:52:33 +0300 > Imre Deak wrote: > > > From: Steve Sakoman > > > > Add LCD support for OMAP3 EVM > > > > Backlight support by Arun C > > > > Signed-off-by: Steve Sakoman > > Acked-by: Syed Mohammed Khasim > > Signed-off-by: Tony Lindgren > > Fixed-by: Jarkko Nikula > > Fixed-by: David Brownell > > Signed-off-by: Imre Deak > > --- > > drivers/video/omap/Makefile | 1 + > > drivers/video/omap/lcd_omap3evm.c | 191 +++++++++++++++++++++++++++++++++++++ > > 2 files changed, 192 insertions(+), 0 deletions(-) > > create mode 100644 drivers/video/omap/lcd_omap3evm.c > > > > diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile > > index 96d2d43..4345157 100644 > > --- a/drivers/video/omap/Makefile > > +++ b/drivers/video/omap/Makefile > > @@ -30,6 +30,7 @@ objs-y$(CONFIG_MACH_OMAP_APOLLON) += lcd_apollon.o > > objs-y$(CONFIG_MACH_OMAP_2430SDP) += lcd_2430sdp.o > > objs-y$(CONFIG_MACH_OMAP_3430SDP) += lcd_2430sdp.o > > objs-y$(CONFIG_MACH_OMAP2EVM) += lcd_omap2evm.o > > +objs-y$(CONFIG_MACH_OMAP3EVM) += lcd_omap3evm.o > > objs-y$(CONFIG_FB_OMAP_LCD_MIPID) += lcd_mipid.o > > > > omapfb-objs := $(objs-yy) > > diff --git a/drivers/video/omap/lcd_omap3evm.c b/drivers/video/omap/lcd_omap3evm.c > > new file mode 100644 > > index 0000000..1c3d814 > > --- /dev/null > > +++ b/drivers/video/omap/lcd_omap3evm.c > > @@ -0,0 +1,191 @@ > > +/* > > + * LCD panel support for the TI OMAP3 EVM board > > + * > > + * Author: Steve Sakoman > > + * > > + * Derived from drivers/video/omap/lcd-apollon.c > > + * > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by the > > + * Free Software Foundation; either version 2 of the License, or (at your > > + * option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, but > > + * WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License along > > + * with this program; if not, write to the Free Software Foundation, Inc., > > + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#define LCD_PANEL_ENABLE_GPIO 153 > > +#define LCD_PANEL_LR 2 > > +#define LCD_PANEL_UD 3 > > +#define LCD_PANEL_INI 152 > > +#define LCD_PANEL_QVGA 154 > > +#define LCD_PANEL_RESB 155 > > + > > +#define LCD_XRES 480 > > +#define LCD_YRES 640 > > +#define LCD_PIXCLOCK 26000 /* in kHz */ > > + > > You can drop defines used only once. There are no such defines for > other panels. Ok, will fix this and similar places in the other panel drivers. --Imre