From: Imre Deak <imre.deak@nokia.com>
To: ext Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Antonino Daplas <adaplas@gmail.com>,
"linux-fbdev-devel@lists.sourceforge.net"
<linux-fbdev-devel@lists.sourceforge.net>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
"Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>,
"Stanley.Miao" <stanley.miao@windriver.com>
Subject: Re: [PATCH 11/20] omapfb: Add support for the ZOOM MDK LCD
Date: Tue, 16 Jun 2009 14:10:44 +0300 [thread overview]
Message-ID: <20090616111044.GF32105@localhost> (raw)
In-Reply-To: <20090614234716.fa6f8f4b.krzysztof.h1@poczta.fm>
On Sun, Jun 14, 2009 at 11:47:16PM +0200, ext Krzysztof Helt wrote:
> On Thu, 4 Jun 2009 20:52:36 +0300
> Imre Deak <imre.deak@nokia.com> wrote:
> [...]
> > diff --git a/drivers/video/omap/lcd_ldp.c b/drivers/video/omap/lcd_ldp.c
> > new file mode 100644
> > index 0000000..8925230
> > --- /dev/null
> > +++ b/drivers/video/omap/lcd_ldp.c
> > [...]
> > +static void ldp_panel_disable(struct lcd_panel *panel)
> > +{
> > + gpio_direction_output(LCD_PANEL_ENABLE_GPIO, 0);
> > + gpio_direction_output(LCD_PANEL_BACKLIGHT_GPIO, 0);
> > +
> > + t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEDICATED);
> > + t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEV_GRP);
> > + mdelay(4);
>
> Use the msleep() instead of the mdelay().
Ok, will fix it and the similar places in the other panel drivers.
--Imre
next prev parent reply other threads:[~2009-06-16 11:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 17:52 [PATCH 00/20] omapfb: Add support for new LCDs / misc fixes Imre Deak
2009-06-04 17:52 ` [PATCH 01/20] omapfb: Add support for the Apollon LCD Imre Deak
2009-06-04 17:52 ` [PATCH 02/20] omapfb: Add support for MIPI-DCS compatible LCDs Imre Deak
[not found] ` <20090608004324.6c5ecf17.krzysztof.h1@poczta.fm>
2009-06-09 11:15 ` [Linux-fbdev-devel] " Imre Deak
2009-06-10 14:48 ` [PATCH] " Imre Deak
2009-06-14 21:48 ` [Linux-fbdev-devel] [PATCH 02/20] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 03/20] N770: Enable LCD MIPI-DCS in Kconfig Imre Deak
2009-06-04 17:52 ` [PATCH 04/20] omapfb: Add support for the Amstrad Delta LCD Imre Deak
2009-06-05 10:38 ` Janusz Krzysztofik
2009-06-05 11:39 ` Janusz Krzysztofik
2009-06-05 15:39 ` Jonathan McDowell
2009-06-14 21:27 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 05/20] omapfb: Add support for the 2430SDP LCD Imre Deak
2009-06-14 21:29 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-16 10:47 ` Imre Deak
2009-06-04 17:52 ` [PATCH 06/20] omapfb: Add support for the OMAP2EVM LCD Imre Deak
2009-06-14 21:30 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-16 10:51 ` Imre Deak
2009-06-04 17:52 ` [PATCH 07/20] omapfb: Add support for the 3430SDP LCD Imre Deak
2009-06-14 21:31 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 08/20] omapfb: Add support for the OMAP3 EVM LCD Imre Deak
2009-06-14 21:33 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-16 10:54 ` Imre Deak
2009-06-04 17:52 ` [PATCH 09/20] omapfb: Add support for the OMAP3 Beagle DVI output Imre Deak
2009-06-14 21:34 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 10/20] omapfb: Add support for the Gumstix Overo LCD Imre Deak
2009-06-14 21:35 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 11/20] omapfb: Add support for the ZOOM MDK LCD Imre Deak
2009-06-14 21:37 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-14 21:47 ` Krzysztof Helt
2009-06-16 11:10 ` Imre Deak [this message]
2009-06-04 17:52 ` [PATCH 12/20] omapfb: Add support for rotation on the Blizzard LCD ctrl Imre Deak
2009-06-14 21:38 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 13/20] omapfb: dispc: Various typo fixes Imre Deak
2009-06-14 21:38 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 14/20] omapfb: dispc: Disable iface clocks along with func clocks Imre Deak
2009-06-14 21:39 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 15/20] omapfb: dispc: Enable wake up capability Imre Deak
2009-06-14 21:40 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 16/20] omapfb: dispc: Allow multiple external IRQ handlers Imre Deak
2009-06-14 21:41 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 17/20] omapfb: suspend/resume only if FB device is already initialized Imre Deak
2009-06-14 21:42 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 18/20] omapfb: Fix coding style / remove dead line Imre Deak
2009-06-14 21:43 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 19/20] omapfb: Add FB manual update option to Kconfig Imre Deak
2009-06-14 21:44 ` [Linux-fbdev-devel] " Krzysztof Helt
2009-06-04 17:52 ` [PATCH 20/20] omapfb: HWA742: fix pointer to be const Imre Deak
2009-06-14 21:45 ` Krzysztof Helt
2009-06-07 22:41 ` [Linux-fbdev-devel] [PATCH 01/20] omapfb: Add support for the Apollon LCD Krzysztof Helt
2009-06-04 21:00 ` [Linux-fbdev-devel] [PATCH 00/20] omapfb: Add support for new LCDs / misc fixes Krzysztof Helt
2009-06-11 12:02 ` [PULL REQUEST] " Imre Deak
2009-06-16 16:58 ` Krzysztof Helt
2009-06-17 10:25 ` Imre Deak
2009-06-22 19:17 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616111044.GF32105@localhost \
--to=imre.deak@nokia.com \
--cc=Tomi.Valkeinen@nokia.com \
--cc=adaplas@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-omap@vger.kernel.org \
--cc=stanley.miao@windriver.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).