From: Andrew Morton <akpm@linux-foundation.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.30] nvidiafb: fix missing space in log message
Date: Mon, 22 Jun 2009 23:11:31 -0700 [thread overview]
Message-ID: <20090622231131.772eea06.akpm@linux-foundation.org> (raw)
In-Reply-To: <18999.49010.127368.554600@pilspetsen.it.uu.se>
On Tue, 16 Jun 2009 17:51:14 +0200 Mikael Pettersson <mikpe@it.uu.se> wrote:
> On bootup nvidiafb prints the following on my Apple G5:
>
> nvidiafb: CRTC 1appears to have a CRT attached
>
> There should be a space between the '1' and the 'appears'.
>
> Fix: add the space
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
>
> diff -rupN linux-2.6.30/drivers/video/nvidia/nv_setup.c linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c
> --- linux-2.6.30/drivers/video/nvidia/nv_setup.c 2009-06-10 12:00:46.000000000 +0200
> +++ linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c 2009-06-16 17:41:21.000000000 +0200
> @@ -543,7 +543,7 @@ int NVCommonSetup(struct fb_info *info)
> } else if (analog_on_B) {
> CRTCnumber = outputBfromCRTC;
> FlatPanel = 0;
> - printk("nvidiafb: CRTC %i"
> + printk("nvidiafb: CRTC %i "
> "appears to have a "
> "CRT attached\n", CRTCnumber);
> } else if (slaved_on_A) {
Yeah, someone seems to have gone checkpatch-crazy there.
Let's be slightly less nutty and do
--- a/drivers/video/nvidia/nv_setup.c~nvidiafb-fix-missing-space-in-log-message
+++ a/drivers/video/nvidia/nv_setup.c
@@ -543,8 +543,7 @@ int NVCommonSetup(struct fb_info *info)
} else if (analog_on_B) {
CRTCnumber = outputBfromCRTC;
FlatPanel = 0;
- printk("nvidiafb: CRTC %i"
- "appears to have a "
+ printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
} else if (slaved_on_A) {
CRTCnumber = 0;
_
Which happens to exactly copy the printk from five lines earlier...
} else if (analog_on_A) {
CRTCnumber = outputAfromCRTC;
FlatPanel = 0;
printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
} else if (analog_on_B) {
CRTCnumber = outputBfromCRTC;
FlatPanel = 0;
printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
prev parent reply other threads:[~2009-06-23 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 15:51 [PATCH 2.6.30] nvidiafb: fix missing space in log message Mikael Pettersson
2009-06-23 6:11 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622231131.772eea06.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).