* [PATCH 2.6.30] nvidiafb: fix missing space in log message
@ 2009-06-16 15:51 Mikael Pettersson
2009-06-23 6:11 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2009-06-16 15:51 UTC (permalink / raw)
To: adaplas; +Cc: linux-fbdev-devel, linux-kernel
On bootup nvidiafb prints the following on my Apple G5:
nvidiafb: CRTC 1appears to have a CRT attached
There should be a space between the '1' and the 'appears'.
Fix: add the space
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
diff -rupN linux-2.6.30/drivers/video/nvidia/nv_setup.c linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c
--- linux-2.6.30/drivers/video/nvidia/nv_setup.c 2009-06-10 12:00:46.000000000 +0200
+++ linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c 2009-06-16 17:41:21.000000000 +0200
@@ -543,7 +543,7 @@ int NVCommonSetup(struct fb_info *info)
} else if (analog_on_B) {
CRTCnumber = outputBfromCRTC;
FlatPanel = 0;
- printk("nvidiafb: CRTC %i"
+ printk("nvidiafb: CRTC %i "
"appears to have a "
"CRT attached\n", CRTCnumber);
} else if (slaved_on_A) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.30] nvidiafb: fix missing space in log message
2009-06-16 15:51 [PATCH 2.6.30] nvidiafb: fix missing space in log message Mikael Pettersson
@ 2009-06-23 6:11 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-06-23 6:11 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-fbdev-devel, linux-kernel
On Tue, 16 Jun 2009 17:51:14 +0200 Mikael Pettersson <mikpe@it.uu.se> wrote:
> On bootup nvidiafb prints the following on my Apple G5:
>
> nvidiafb: CRTC 1appears to have a CRT attached
>
> There should be a space between the '1' and the 'appears'.
>
> Fix: add the space
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
>
> diff -rupN linux-2.6.30/drivers/video/nvidia/nv_setup.c linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c
> --- linux-2.6.30/drivers/video/nvidia/nv_setup.c 2009-06-10 12:00:46.000000000 +0200
> +++ linux-2.6.30.nvidiafb-logmsg-missing-space/drivers/video/nvidia/nv_setup.c 2009-06-16 17:41:21.000000000 +0200
> @@ -543,7 +543,7 @@ int NVCommonSetup(struct fb_info *info)
> } else if (analog_on_B) {
> CRTCnumber = outputBfromCRTC;
> FlatPanel = 0;
> - printk("nvidiafb: CRTC %i"
> + printk("nvidiafb: CRTC %i "
> "appears to have a "
> "CRT attached\n", CRTCnumber);
> } else if (slaved_on_A) {
Yeah, someone seems to have gone checkpatch-crazy there.
Let's be slightly less nutty and do
--- a/drivers/video/nvidia/nv_setup.c~nvidiafb-fix-missing-space-in-log-message
+++ a/drivers/video/nvidia/nv_setup.c
@@ -543,8 +543,7 @@ int NVCommonSetup(struct fb_info *info)
} else if (analog_on_B) {
CRTCnumber = outputBfromCRTC;
FlatPanel = 0;
- printk("nvidiafb: CRTC %i"
- "appears to have a "
+ printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
} else if (slaved_on_A) {
CRTCnumber = 0;
_
Which happens to exactly copy the printk from five lines earlier...
} else if (analog_on_A) {
CRTCnumber = outputAfromCRTC;
FlatPanel = 0;
printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
} else if (analog_on_B) {
CRTCnumber = outputBfromCRTC;
FlatPanel = 0;
printk("nvidiafb: CRTC %i appears to have a "
"CRT attached\n", CRTCnumber);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-23 6:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-16 15:51 [PATCH 2.6.30] nvidiafb: fix missing space in log message Mikael Pettersson
2009-06-23 6:11 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).