From: "Ville Syrjälä" <syrjala@sci.fi>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Russell King <linux@arm.linux.org.uk>,
Antonino Daplas <adaplas@gmail.com>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Thomas Winischhofer <thomas@winischhofer.net>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 18/19] drivers/video: Use PCI_VDEVICE
Date: Fri, 26 Jun 2009 20:31:05 +0300 [thread overview]
Message-ID: <20090626173105.GI9980@sci.fi> (raw)
In-Reply-To: <1246034126.18587.19.camel@Joe-Laptop.home>
On Fri, Jun 26, 2009 at 09:35:26AM -0700, Joe Perches wrote:
> On Fri, 2009-06-26 at 12:54 +0300, Ville Syrjälä wrote:
> > Perhaps there should be a PCI_VDDEVICE() or something for this type of
> > stuff? Would make things even shorter.
>
> drivers/edac/edac_core.h has:
>
> #define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
> PCI_DEVICE_ID_ ## vend ## _ ## dev
>
> Try submitting a patch and see what happens...
Too lazy. I was thinking that since you're already looking at
this stuff you might be tricked into doing some more work.
> > It seems your script missed atyfb. It could use PCI_VDEVICE() too.
>
> Can you show an example please?
I didn't read you script and didn't look at the patches too closely. It
seems you only converted the open-coded stuff and not stuff already
using the PCI_DEVICE() macro. atyfb falls into this category.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
prev parent reply other threads:[~2009-06-26 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1245906151.git.joe@perches.com>
2009-06-25 5:13 ` [PATCH 18/19] drivers/video: Use PCI_VDEVICE Joe Perches
2009-06-26 9:54 ` Ville Syrjälä
2009-06-26 16:35 ` Joe Perches
2009-06-26 17:31 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626173105.GI9980@sci.fi \
--to=syrjala@sci.fi \
--cc=adaplas@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=joe@perches.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paulus@samba.org \
--cc=thomas@winischhofer.net \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).