From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: Geert Uytterhoeven <geert.uytterhoeven@gmail.com>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [Linux-fbdev-devel] [PATCH 3/3] drivers/video: Correct use of request_region/request_mem_region
Date: Mon, 12 Oct 2009 02:29:07 +0200 [thread overview]
Message-ID: <20091012002907.GA835@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908091141150.13271@ask.diku.dk>
On Sun, Aug 09, 2009 at 11:42:32AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> request_region should be used with release_region, not request_mem_region.
>
> Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c,
> the problem is actually the other way around; request_mem_region should be
> used instead of request_region.
>
> The semantic patch that finds/fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> expression start;
> @@
>
> request_region(start,...)
>
> @b1@
> expression r1.start;
> @@
>
> request_mem_region(start,...)
>
> @depends on !b1@
> expression r1.start;
> expression E;
> @@
>
> - release_mem_region
> + release_region
> (start,E)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Any reason this still hasn't been applied?
Ralf
next prev parent reply other threads:[~2009-10-12 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-09 7:44 [PATCH 3/3] drivers/video: Correct use of request_region/request_mem_region Julia Lawall
2009-08-09 9:24 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-08-09 9:33 ` Julia Lawall
2009-08-09 9:42 ` Julia Lawall
2009-10-12 0:29 ` Ralf Baechle [this message]
2009-10-14 13:40 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012002907.GA835@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert.uytterhoeven@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).