Re: [PATCH] fbdev: Fix test on unsigned in fb_do_show_logo()

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 17 Oct 2009 00:45:14 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:

> image->d[xy] are unsigned so the check was wrong.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index 99bbd28..9f20641 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -403,7 +403,8 @@ static void fb_do_show_logo(struct fb_info *info, struct fb_image *image,
>  			image->dx += image->width + 8;
>  		}
>  	} else if (rotate == FB_ROTATE_UD) {
> -		for (x = 0; x < num && image->dx >= 0; x++) {
> +		for (x = 0; x < num && image->dx + image->width + 8 >= 0;
> +				x++) {
>  			info->fbops->fb_imageblit(info, image);
>  			image->dx -= image->width + 8;
>  		}
> @@ -415,7 +416,8 @@ static void fb_do_show_logo(struct fb_info *info, struct fb_image *image,
>  			image->dy += image->height + 8;
>  		}
>  	} else if (rotate == FB_ROTATE_CCW) {
> -		for (x = 0; x < num && image->dy >= 0; x++) {
> +		for (x = 0; x < num && image->dy + image->height + 8 >= 0;
> +				x++) {
>  			info->fbops->fb_imageblit(info, image);
>  			image->dy -= image->height + 8;
>  		}

Presumably that test isn't needed at all?

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference