From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] pxa: support pxa168 LCD controller SPI operation
Date: Thu, 12 Nov 2009 22:17:53 +0000 [thread overview]
Message-ID: <20091112221753.GD12308@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <7c34ac520911111816q22dcf293r98d67a588bf83913@mail.gmail.com>
On Thu, Nov 12, 2009 at 10:16:16AM +0800, Jun Nie wrote:
> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
> index 84d8327..e1f1c5f 100644
> --- a/drivers/video/pxa168fb.c
> +++ b/drivers/video/pxa168fb.c
> @@ -27,12 +27,90 @@
> #include <linux/clk.h>
> #include <linux/err.h>
> #include <linux/uaccess.h>
> +#include <linux/gpio.h>
> #include <video/pxa168fb.h>
>
> +#include <mach/gpio.h>
If you include linux/gpio.h, then if the right configuration symbol
(CONFIG_GENERIC_GPIO) is selected, asm/gpio.h and therefore mach/gpio.h
will be included for you.
> +static inline void spi_gpio_assert(int spi_gpio_cs, int val)
> +{
> + if (gpio_is_valid(spi_gpio_cs))
> + gpio_set_value(spi_gpio_cs, val);
This seems to have style problems - please run it through checkpatch.
next prev parent reply other threads:[~2009-11-12 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 8:12 [PATCH 1/8] pxa: support pxa168 LCD controller SPI operation Jun Nie
2009-11-12 2:16 ` Jun Nie
2009-11-12 22:17 ` Russell King - ARM Linux [this message]
2009-11-16 9:34 ` Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112221753.GD12308@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).