From: Dan Carpenter <error27@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: JosephChan@via.com.tw, ScottFang@viatech.com.cn
Subject: [patch] fix oops with no /proc
Date: Sun, 22 Nov 2009 16:21:11 +0200 [thread overview]
Message-ID: <20091122142111.GA28155@bicker> (raw)
Fixed a typo: missing *. This would lead to a kernel oops if the kernel
was compiled without support for the /proc file system.
Found with a static checker. Compile tested.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/video/via/viafbdev.c 2009-11-21 14:44:33.000000000 +0200
+++ devel/drivers/video/via/viafbdev.c 2009-11-21 14:44:43.000000000 +0200
@@ -1797,7 +1797,7 @@ static const struct file_operations viaf
static void viafb_init_proc(struct proc_dir_entry **viafb_entry)
{
*viafb_entry = proc_mkdir("viafb", NULL);
- if (viafb_entry) {
+ if (*viafb_entry) {
proc_create("dvp0", 0, *viafb_entry, &viafb_dvp0_proc_fops);
proc_create("dvp1", 0, *viafb_entry, &viafb_dvp1_proc_fops);
proc_create("dfph", 0, *viafb_entry, &viafb_dfph_proc_fops);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
next reply other threads:[~2009-11-22 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 14:21 Dan Carpenter [this message]
2009-11-25 17:46 ` [patch] fix oops with no /proc Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091122142111.GA28155@bicker \
--to=error27@gmail.com \
--cc=JosephChan@via.com.tw \
--cc=ScottFang@viatech.com.cn \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).