From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Antonino Daplas <adaplas@pol.net>,
linux-fbdev-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 01/29] move acornfb's probe function to .devinit.text
Date: Tue, 26 Jan 2010 09:46:41 +0100 [thread overview]
Message-ID: <20100126084641.GB20792@pengutronix.de> (raw)
In-Reply-To: <20100123232813.GB4146@x200>
On Sun, Jan 24, 2010 at 01:25:58 +0200, Alexey Dobriyan wrote:
> gods, can you just send one patch for all framebuffer drivers?
Well, I thought one logical change per changeset is the favourite way to
go. And as the people Cc:d are different I think most people prefer it
this way.
On Sun, Jan 24, 2010 at 01:28:13AM +0200, Alexey Dobriyan wrote:
> On Sat, Jan 23, 2010 at 09:35:09PM +0100, Uwe Kleine-König wrote:
> > -static int __init acornfb_probe(struct platform_device *dev)
> > +static int __devinit acornfb_probe(struct platform_device *dev)
>
> Even more, if this function is marked __devinit, some other functions
> can very well be marked __devinit, can you do this?
Probably, the big pro after my patch is that modpost can warn about
this. Actually this applies to all (initially) over 50 patches in this
series. If you take my patches, squash them together and fix all called
functions, I'm happy, too.
If you don't I might come back to this and do it myself.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2010-01-26 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de>
2010-01-23 20:35 ` [PATCH 01/29] move acornfb's probe function to .devinit.text Uwe Kleine-König
2010-01-23 23:25 ` Alexey Dobriyan
2010-01-23 23:28 ` Alexey Dobriyan
2010-01-26 8:46 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126084641.GB20792@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=adaplas@pol.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hch@lst.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).