* [Fwd: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)]
@ 2010-01-20 11:16 Christoph Egger
2010-01-27 9:44 ` [fwd: " Christoph Egger
2010-02-05 15:14 ` [fwd: [PATCH] obsolete config in kernel source James Simmons
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Egger @ 2010-01-20 11:16 UTC (permalink / raw)
To: linux-fbdev
----- Forwarded message from Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> -----
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc: siccegge@stud.informatik.uni-erlangen.de,
Reinhard.Tartler@informatik.uni-erlangen.de
Subject: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)
Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
While probably not strictly a integrity violation (as
FB_SOFT_CURSOR can still be set as it is once mentioned in a KConfig
select statement this looks like a left-over of
c465e05a03209651078b95686158648fd7ed84c5
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
From 5461c8d1ebc54e9f5c86233aa831cefc7c06a140 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Fri, 15 Jan 2010 11:03:50 +0100
Subject: [PATCH 1/4] Clean missed bit of FB_SOFT_CURSOR
While the config Option FB_SOFT_BUFFER was removed in
c465e05a03209651078b95686158648fd7ed84c5 while moving to fbcon this
single driver has it left as a select in KConfig / #ifdef in
source. This last occurence is removed here so the option is really
gone
Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
drivers/video/Kconfig | 1 -
drivers/video/sis/sis_main.c | 3 ---
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 5a5c303..7fe1839 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1494,7 +1494,6 @@ config FB_VIA
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_SOFT_CURSOR
select I2C_ALGOBIT
select I2C
help
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 9d2b6bc..a531a0f 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
@@ -1891,9 +1891,6 @@ static struct fb_ops sisfb_ops = {
.fb_fillrect = fbcon_sis_fillrect,
.fb_copyarea = fbcon_sis_copyarea,
.fb_imageblit = cfb_imageblit,
-#ifdef CONFIG_FB_SOFT_CURSOR
- .fb_cursor = soft_cursor,
-#endif
.fb_sync = fbcon_sis_sync,
#ifdef SIS_NEW_CONFIG_COMPAT
.fb_compat_ioctl= sisfb_ioctl,
--
1.6.3.3
----- End forwarded message -----
^ permalink raw reply related [flat|nested] 3+ messages in thread* [fwd: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)]
2010-01-20 11:16 [Fwd: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)] Christoph Egger
@ 2010-01-27 9:44 ` Christoph Egger
2010-02-05 15:14 ` [fwd: [PATCH] obsolete config in kernel source James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Egger @ 2010-01-27 9:44 UTC (permalink / raw)
To: linux-fbdev
----- Forwarded message from Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> -----
Date: Fri, 15 Jan 2010 13:27:56 +0100
Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
While probably not strictly a integrity violation (as
FB_SOFT_CURSOR can still be set as it is once mentioned in a KConfig
select statement this looks like a left-over of
c465e05a03209651078b95686158648fd7ed84c5
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
From 5461c8d1ebc54e9f5c86233aa831cefc7c06a140 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Fri, 15 Jan 2010 11:03:50 +0100
Subject: [PATCH] Clean missed bit of FB_SOFT_CURSOR
While the config Option FB_SOFT_BUFFER was removed in
c465e05a03209651078b95686158648fd7ed84c5 while moving to fbcon this
single driver has it left as a select in KConfig / #ifdef in
source. This last occurence is removed here so the option is really
gone
Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
drivers/video/Kconfig | 1 -
drivers/video/sis/sis_main.c | 3 ---
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 5a5c303..7fe1839 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1494,7 +1494,6 @@ config FB_VIA
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
- select FB_SOFT_CURSOR
select I2C_ALGOBIT
select I2C
help
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 9d2b6bc..a531a0f 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
@@ -1891,9 +1891,6 @@ static struct fb_ops sisfb_ops = {
.fb_fillrect = fbcon_sis_fillrect,
.fb_copyarea = fbcon_sis_copyarea,
.fb_imageblit = cfb_imageblit,
-#ifdef CONFIG_FB_SOFT_CURSOR
- .fb_cursor = soft_cursor,
-#endif
.fb_sync = fbcon_sis_sync,
#ifdef SIS_NEW_CONFIG_COMPAT
.fb_compat_ioctl= sisfb_ioctl,
--
1.6.3.3
----- End forwarded message -----
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [fwd: [PATCH] obsolete config in kernel source
2010-01-20 11:16 [Fwd: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)] Christoph Egger
2010-01-27 9:44 ` [fwd: " Christoph Egger
@ 2010-02-05 15:14 ` James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: James Simmons @ 2010-02-05 15:14 UTC (permalink / raw)
To: linux-fbdev
> ----- Forwarded message from Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> -----
>
> Date: Fri, 15 Jan 2010 13:27:56 +0100
>
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> While probably not strictly a integrity violation (as
> FB_SOFT_CURSOR can still be set as it is once mentioned in a KConfig
> select statement this looks like a left-over of
> c465e05a03209651078b95686158648fd7ed84c5
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
>
> Regards
>
> Christoph Egger
>
> [0] http://vamos1.informatik.uni-erlangen.de/
>
> >From 5461c8d1ebc54e9f5c86233aa831cefc7c06a140 Mon Sep 17 00:00:00 2001
> From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
> Date: Fri, 15 Jan 2010 11:03:50 +0100
> Subject: [PATCH] Clean missed bit of FB_SOFT_CURSOR
>
> While the config Option FB_SOFT_BUFFER was removed in
> c465e05a03209651078b95686158648fd7ed84c5 while moving to fbcon this
> single driver has it left as a select in KConfig / #ifdef in
> source. This last occurence is removed here so the option is really
> gone
>
> Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Acked-by: James Simmons <jsimmons@infradead.org>
Patches is fine.
> drivers/video/Kconfig | 1 -
> drivers/video/sis/sis_main.c | 3 ---
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 5a5c303..7fe1839 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1494,7 +1494,6 @@ config FB_VIA
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> - select FB_SOFT_CURSOR
> select I2C_ALGOBIT
> select I2C
> help
> diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
> index 9d2b6bc..a531a0f 100644
> --- a/drivers/video/sis/sis_main.c
> +++ b/drivers/video/sis/sis_main.c
> @@ -1891,9 +1891,6 @@ static struct fb_ops sisfb_ops = {
> .fb_fillrect = fbcon_sis_fillrect,
> .fb_copyarea = fbcon_sis_copyarea,
> .fb_imageblit = cfb_imageblit,
> -#ifdef CONFIG_FB_SOFT_CURSOR
> - .fb_cursor = soft_cursor,
> -#endif
> .fb_sync = fbcon_sis_sync,
> #ifdef SIS_NEW_CONFIG_COMPAT
> .fb_compat_ioctl= sisfb_ioctl,
> --
> 1.6.3.3
>
>
>
> ----- End forwarded message -----
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-05 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 11:16 [Fwd: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)] Christoph Egger
2010-01-27 9:44 ` [fwd: " Christoph Egger
2010-02-05 15:14 ` [fwd: [PATCH] obsolete config in kernel source James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).