From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Thu, 28 Jan 2010 08:19:57 +0000 Subject: Re: [PATCH] imxfb: correct location of callbacks in suspend and Message-Id: <20100128001957.408936b2.akpm@linux-foundation.org> List-Id: References: <1263226881-28008-1-git-send-email-u.kleine-koenig@pengutronix.de> <1264433854-878-1-git-send-email-u.kleine-koenig@pengutronix.de> <20100127154818.de91e255.akpm@linux-foundation.org> <20100128074101.GA13756@pengutronix.de> In-Reply-To: <20100128074101.GA13756@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, 28 Jan 2010 08:41:01 +0100 Uwe Kleine-K__nig wrote: > > What were the runtime effects of this bug? > For me it was that in the original imxfb_info *fbi backlight_power was > NULL but in imxfb_suspend it was 4 resulting in an oops as imxfb_suspend > calls imxfb_disable_controller(fbi) which in turn has > > if (fbi->backlight_power) > fbi->backlight_power(0); OK, thanks, that was important info. I rescheduled the patch for 2.6.33 and marked it for 2.6.32.x backporting.