From: "Ville Syrjälä" <syrjala@sci.fi>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] OMAP: DSS2: OMAPFB: implement
Date: Thu, 04 Feb 2010 23:05:12 +0000 [thread overview]
Message-ID: <20100204230512.GA10145@sci.fi> (raw)
In-Reply-To: <1265297486-22438-2-git-send-email-tomi.valkeinen@nokia.com>
On Thu, Feb 04, 2010 at 05:31:26PM +0200, Tomi Valkeinen wrote:
> Previously the only place to get the size of the display was from the
> DSS's sysfs interface, making, for example, configuring overlays and doing
> updates on manual displays more difficult.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> ---
> drivers/video/omap2/omapfb/omapfb-ioctl.c | 18 ++++++++++++++++++
> include/linux/omapfb.h | 7 +++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
<snip>
> @@ -216,6 +217,12 @@ struct omapfb_tearsync_info {
> __u16 reserved2;
> };
>
> +struct omapfb_display_info {
> + __u16 width;
> + __u16 height;
How about adding the physical display size here as well? I suppose
mm is the standard unit for such things but for small displays more
accuracy might be nice.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2010-02-04 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 15:31 [PATCH 1/2] OMAP: DSS2: OMAPFB: implement OMAPFB_RESERVE_BUFFER Tomi Valkeinen
2010-02-04 15:31 ` [PATCH 2/2] OMAP: DSS2: OMAPFB: implement OMAPFB_GET_DISPLAY_INFO Tomi Valkeinen
2010-02-04 23:05 ` Ville Syrjälä [this message]
2010-02-05 9:28 ` [PATCH 2/2] OMAP: DSS2: OMAPFB: implement Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204230512.GA10145@sci.fi \
--to=syrjala@sci.fi \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).