From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: move FBIO_WAITFORVSYNC to linux/fb.h
Date: Tue, 20 Apr 2010 22:54:45 +0000 [thread overview]
Message-ID: <20100420155445.11776163.akpm@linux-foundation.org> (raw)
In-Reply-To: <1271429829-23577-1-git-send-email-notasas@gmail.com>
On Tue, 20 Apr 2010 14:35:10 +0530
"Hiremath, Vaibhav" <hvaibhav@ti.com> wrote:
> ...
>
> > --- a/include/linux/fb.h
> > +++ b/include/linux/fb.h
> > @@ -23,6 +23,8 @@ struct dentry;
> > #else
> > #define FBIO_CURSOR _IOWR('F', 0x08, struct fb_cursor)
> > #endif
> > +#define FBIO_WAITFORVSYNC _IOW('F', 0x20, __u32)
> > +
> [Hiremath, Vaibhav] Do not insert it in middle, lets follow the sequence and append it at last. Otherwise looks ok to me.
Confused. That definition appears to be in the appropriate place to me.
> We should merge this patch.
>
> There are some other drivers (like OMAP) which define WAITFORVSYNC ioctl with custom (OMAPFB_WAITFORVSYNC) way needs to be changed for this.
>
> I will change them and submit it to list.
Please cc myself...
next prev parent reply other threads:[~2010-04-20 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 14:57 [PATCH] fbdev: move FBIO_WAITFORVSYNC to linux/fb.h Grazvydas Ignotas
2010-04-20 9:17 ` Hiremath, Vaibhav
2010-04-20 22:54 ` Andrew Morton [this message]
2010-04-21 4:29 ` Hiremath, Vaibhav
2010-04-21 13:21 ` James Simmons
2010-04-21 13:36 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420155445.11776163.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).