From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sh: make interrupt resource optional in SH framebuffer driver
Date: Sat, 01 May 2010 12:55:00 +0000 [thread overview]
Message-ID: <20100501125500.GA29020@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1004301805371.4055@axis700.grange>
On Sat, May 01, 2010 at 09:43:14PM +0900, Magnus Damm wrote:
> On Sat, May 1, 2010 at 9:15 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > On Sat, 1 May 2010, Magnus Damm wrote:
> >> Why? Doesn't the LCDC hardware block always come with an IRQ line?
> >
> > Because on AP4 intcs is not supported in the mainline yet. And because we
> > can?;) Some code paths in the driver already care for the case, when no
> > IRQ is configured, so, we can just use it.
>
> Patches for INTCS have been posted for SH-Mobile ARM G3/G4/AP4. They
> will be part of the upcoming .35 release. The merge order dependencies
> are a bit tricky, so please apply whatever needed locally for now.
>
> I don't agree with you that allowing people to not hook up an IRQ is a
> good thing. The driver already has too many different modes of
> operation, adding another one will just make it more error prone.
> Trying to reduce the number of special cases is the way forward, not
> making yet another one...
>
I tend to agree. Adding functionality for functionality's sake really
only creates an undue maintenance burden. If there are LCDC blocks that
don't have IRQ lines, then of course we will have to do something like
this. If we're just waiting on patches to get upstream in order to enable
the IRQs then I don't really see the point -- there are out of tree
patches we're waiting on in both cases, so this can only really be
considered a stop-gap until the intcs patches are merged anyways,
especially since we'll still want to enable the IRQs on AP4 once those
patches are merged.
next prev parent reply other threads:[~2010-05-01 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 16:07 [PATCH 2/2] sh: make interrupt resource optional in SH framebuffer Guennadi Liakhovetski
2010-05-01 12:08 ` [PATCH 2/2] sh: make interrupt resource optional in SH Magnus Damm
2010-05-01 12:15 ` [PATCH 2/2] sh: make interrupt resource optional in SH framebuffer Guennadi Liakhovetski
2010-05-01 12:43 ` [PATCH 2/2] sh: make interrupt resource optional in SH Magnus Damm
2010-05-01 12:55 ` Paul Mundt [this message]
2010-05-01 20:07 ` [PATCH 2/2] sh: make interrupt resource optional in SH framebuffer Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100501125500.GA29020@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).