From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Mon, 10 May 2010 17:14:43 +0000 Subject: Re: [PATCH] DSS2 Include VRFB into omap2-3build only Message-Id: <20100510171443.GE16460@atomide.com> List-Id: References: <1273474110-22451-1-git-send-email-svadivu@ti.com> <1A2F53DA-903A-4667-A27F-492A3499F7ED@student.utwente.nl> <73F3CED4-60D5-4351-A921-335110542B6F@dominion.thruhere.net> <4BE7ECE4.5070608@gmail.com> <4BE8063B.1080709@ti.com> In-Reply-To: <4BE8063B.1080709@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nishanth Menon Cc: Nishanth Menon , "Guruswamy, Senthilvadivu" , Koen Kooi , "linux-omap@vger.kernel.org" , "tomi.valkeinen@nokia.com" , "Hiremath, Vaibhav" , "linux-fbdev@vger.kernel.org" * Nishanth Menon [100510 06:07]: > On 05/10/2010 06:24 AM, Nishanth Menon wrote: > >On 05/10/2010 03:26 AM, Guruswamy, Senthilvadivu wrote: > >>Tiler support is not yet in OMAP builds. So multi-omap build will NOT break, but would exclude VRFB feature in the build. > >in which case, is'nt this patch redundant :) ? > > > >joking apart, would'nt a set of function pointers be better - the > >function pointers could be runtime initialized. the rotational functions > >for Tiler OR vrfb could be used? > > just an addon -> I can see one more potential user of the FEATURES > framework like dma descriptor feature.. what kind of rotator do we > have? vrfb Vs tiler.. Guys, let's make one thing clear: We want to make sure things compile and boot with the omap3_defconfig for all mach-omap2 machines. This means we must be able to compile in all the drivers (and panels) without breaking other configurations. This is the standard Linux behaviour. Any patches that break this will not get merged. Also, please follow the mailing list etiquette, no more top posting: http://www.elinux.org/Netiquette Regards, Tony