linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: InKi Dae <daeinki@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
	Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH] s3c-fb: added patch series for s5pv210 and some features.
Date: Mon, 10 May 2010 17:22:54 -0400	[thread overview]
Message-ID: <20100510172254.1f28f07c.akpm@linux-foundation.org> (raw)
In-Reply-To: <m2g90b950fc1005070059k99d138efr4bfa7de44c58fdd0@mail.gmail.com>

On Fri, 7 May 2010 16:59:56 +0900 InKi Dae <daeinki@gmail.com> wrote:

> this includes three patch series and divides previous patch
> into smaller part.
> 
> so Andrew, please remove my previous patch,
> s3c-fb-add-s5pv210-support-and-some-features.patch from mm tree.
> 
> patch contents are as following.
> 
> 1. s3c_fb_1_3.patch
>   - as patch for supporting s5pv210, CH_ENABLE bit of SHAD
>     register should be enabled to enable window layer on s5pv210.
> 
> 2. s3c_fb_2_3.patch
>    - s5pv210 has five window layers (window0 ~ 4), among them,
>      window0 ~ 2 could be used for local path with fimc(capture device)
>      and fimd writeback feature so this patch makes default window
>      layer for UI to be set at machine code.
> 
> 3. s3c_fb_3_3.patch
>    - it has been working fine at 16bpp but in case of pixel format
>      more then 24bpp it would occur distortedness situation
>      on that mode. so this patch set the word swap control bit of
>      WINCONx to 1 as default value. but it should be set to 0
>      in case that each ENLOCAL bit of WINCON0 ~ 2 registers
>      is enabled. this issue would be solved with local path feature soon.

I prefer not to receive patches this way, sorry.  I will need to detach
the attachments, copy-n-paste the changelogs and signoffs and then
invent meaningful English-language titles for each patch.

The problem is the last part.  The titles I choose may be
inappropriate, and if anyone in a year's time tries to find the history
of a patch by googling for the title, they may not be able to find this
email thread.  A well-chosen title becomes a nice search key for looking
up the patch in reviewion control systems and on the 'net.

There are reasons for the conventions, so please let's be conventional.
Send it as three sequences-numbered emails, one with a carefully chosen
title/Subject: and each one with its own changelog, signoffs, etc.

Also, if you _must_ use attachments, please use text/plain mimetypes,
thanks.

  reply	other threads:[~2010-05-10 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07  7:59 [PATCH] s3c-fb: added patch series for s5pv210 and some features InKi Dae
2010-05-10 21:22 ` Andrew Morton [this message]
2010-05-12  4:07   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100510172254.1f28f07c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=daeinki@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).