From: Andrew Morton <akpm@linux-foundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fb_defio: fix for non-dirty ptes
Date: Thu, 13 May 2010 19:24:36 +0000 [thread overview]
Message-ID: <20100513122436.e69af046.akpm@linux-foundation.org> (raw)
In-Reply-To: <1273697505-23421-1-git-send-email-albert_herranz@yahoo.es>
On Thu, 13 May 2010 07:34:11 +0800
Jaya Kumar <jayakumar.lkml@gmail.com> wrote:
> On Thu, May 13, 2010 at 4:51 AM, Albert Herranz <albert_herranz@yahoo.es> wrote:
> > This patch fixes a problem observed while using fb_defio with a short
> > delay on a PowerPC platform.
> >
> > It is possible that page_mkclean() is invoked in the deferred io work
> > function _before_ a PTE has been marked dirty. In this case, the page
> > is removed from the defio pagelist but page_mkclean() does not
> > write-protect the page again. The end result is that defio ignores all
> > subsequent writes to the page and the corresponding portions of the
> > framebuffer never get updated.
> >
> > The fix consists in keeping track of the pages with non-dirty PTEs,
> > re-checking them again on the next deferred io work iteration.
> > Note that those pages are not passed to the defio callback as they are
> > not written by userspace yet.
> >
> > Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
>
> Looks good to me. Thanks for the bugfix.
>
> Acked-by: Jaya Kumar <jayakumar.lkml@gmail.com>
For some reason my linux-fbdev feed is being stupid and I don't have a
copy of the patch. Resend, please?
next prev parent reply other threads:[~2010-05-13 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 20:51 [PATCH] fb_defio: fix for non-dirty ptes Albert Herranz
2010-05-12 23:34 ` Jaya Kumar
2010-05-13 19:24 ` Andrew Morton [this message]
2010-05-19 16:43 ` Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513122436.e69af046.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).