From: Anatolij Gustschin <agust@denx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sm501fb.c: support mmap on PPC440SPe/PPC440EPx
Date: Wed, 26 May 2010 13:50:28 +0000 [thread overview]
Message-ID: <20100526155028.33c343de@mw.dip.t-dialin.net> (raw)
In-Reply-To: <1274867863-4238-2-git-send-email-agust@denx.de>
On Wed, 26 May 2010 20:13:16 +0900
Ben Dooks <ben@simtec.co.uk> wrote:
> On 26/05/10 18:57, Anatolij Gustschin wrote:
> > Add driver specific mmap function to be able to mmap
> > frame buffer on PPC440SPe/PPC440EPx platforms. This
> > is needed because mmaping of the 36-bit physical
> > address of the frame buffer or MMIO is not supported
> > in generic fb_mmap().
>
> Surely this is something we should be fixing in the
> main fb layer?
We need to store phys addresses > 32-bit somewhere. Changing
smem_start and mmio_start of the struct fb_fix_screeninfo to
unsigned long long would break user space compatibility.
How about adding smem_start_high and mmio_start_high to the
struct fb_fix_screeninfo for the purpose of storing upper
address bits?
next prev parent reply other threads:[~2010-05-26 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 9:57 [PATCH 2/2] sm501fb.c: support mmap on PPC440SPe/PPC440EPx Anatolij Gustschin
2010-05-26 11:13 ` Ben Dooks
2010-05-26 13:50 ` Anatolij Gustschin [this message]
2010-05-28 23:48 ` Andrew Morton
2010-05-30 6:01 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526155028.33c343de@mw.dip.t-dialin.net \
--to=agust@denx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).