From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luotao Fu Date: Thu, 17 Jun 2010 19:22:57 +0000 Subject: Re: [PATCH] video/imxfb: fix suspend when screen is blanked Message-Id: <20100617192257.GA18802@pengutronix.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="tThc/1wpZn/ma/RB" List-Id: References: <1276801147-4103-1-git-send-email-eric@eukrea.com> <1276801147-4103-2-git-send-email-eric@eukrea.com> <1276801147-4103-3-git-send-email-eric@eukrea.com> <1276801147-4103-4-git-send-email-eric@eukrea.com> <1276801147-4103-5-git-send-email-eric@eukrea.com> In-Reply-To: <1276801147-4103-5-git-send-email-eric@eukrea.com> To: linux-arm-kernel@lists.infradead.org --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jun 17, 2010 at 08:59:05PM +0200, Eric B=E9nard wrote: > if the screen is blanked when suspending, the clock is already disabled, > leading to the following log : > WARNING: at arch/arm/plat-mxc/clock.c:59 __clk_disable+0x68/0x74() > Modules linked in: > [] (unwind_backtrace+0x0/0xf8) from [] (warn_slowpath= _common+0x48/0x78) > [] (warn_slowpath_common+0x48/0x78) from [] (__clk_di= sable+0x68/0x74) > [] (__clk_disable+0x68/0x74) from [] (__clk_disable+0= x1c/0x74) > [] (__clk_disable+0x1c/0x74) from [] (clk_disable+0x2= 4/0x34) > [] (clk_disable+0x24/0x34) from [] (imxfb_disable_con= troller+0x38/0x48) > [] (imxfb_disable_controller+0x38/0x48) from [] (imxf= b_suspend+0x14/0x1c) >=20 > Signed-off-by: Eric B=E9nard > Cc: kernel@pengutronix.de > Cc: u.kleine-koenig@pengutronix.de > Cc: linux-fbdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/video/imxfb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c > index b4b6dec..6cbfbff 100644 > --- a/drivers/video/imxfb.c > +++ b/drivers/video/imxfb.c > @@ -597,8 +597,8 @@ static int imxfb_suspend(struct platform_device *dev,= pm_message_t state) > struct imxfb_info *fbi =3D info->par; > =20 > pr_debug("%s\n", __func__); > - > - imxfb_disable_controller(fbi); > + if (readl(fbi->regs + LCDC_RMCR)) > + imxfb_disable_controller(fbi); > return 0; > } I've already submitted a patch to fix this issue: http://lkml.org/lkml/2010/6/3/187 cheers Luotao Fu --=20 Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkwadhEACgkQkLuxfMCkDTagmwCfSF7WaVA7cRMOx+feE1cLi9Xo 3UwAnRHGSK9HJ97VLOg0aHIyjgUTck3X =9PdM -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--