From: Andrew Morton <akpm@linux-foundation.org>
To: inki.dae@samsung.com
Cc: "kmpark@infradead.org" <kmpark@infradead.org>,
"linux-fbdev-devel@lists.sourceforge.net"
<linux-fbdev-devel@lists.sourceforge.net>,
Ben Dooks <ben-linux@fluff.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Thu, 1 Jul 2010 18:46:46 -0700 [thread overview]
Message-ID: <20100701184646.0d33340c.akpm@linux-foundation.org> (raw)
In-Reply-To: <5572310.15091278033672605.JavaMail.weblogic@epml12>
On Fri, 02 Jul 2010 01:21:12 +0000 (GMT) In-Ki Dae <inki.dae@samsung.com> wrote:
> Hi, Andrew,
>
> cpu timing variables could be used generically.
> now fb.h and modedb.c file have been considered only for video mode.
> but the way of transfering screen data includes also command mode(cpu mode or i80 mode)
> so I thought it should be added things for it to fb_varscreeninfo struct.
>
> Could you please tell me why cpu timing variables are specific to s3c-fb?
I dunno - I was just looking at the code.
I don't even know what "cpu timing variables" _are_, in the context of
video drivers. Look at this:
> > CPU interface needs cs, wr setup, wr act and hold delay.
> > I added some members for them to common framework.
It's gobbledigook! Please, write patch descriptions which help poor
dumb people who don't have detailed knowledge of the particular
hardware understand your patch?
next prev parent reply other threads:[~2010-07-02 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 1:21 Re: [PATCH 1/3] FB: Add some members for CPU Interface In-Ki Dae
2010-07-02 1:46 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-29 10:49 InKi Dae
2010-06-30 0:02 ` Jaya Kumar
2010-06-30 4:36 ` InKi Dae
2010-07-01 23:47 ` Jaya Kumar
2010-07-02 7:30 ` Russell King - ARM Linux
2010-07-06 15:30 ` James Simmons
2010-07-06 15:33 ` James Simmons
2010-07-06 15:35 ` James Simmons
2010-07-06 20:23 ` Geert Uytterhoeven
2010-07-07 11:37 ` James Simmons
2010-07-05 8:42 ` Pawel Osciak
2010-06-29 8:31 [PATCH 0/3] ARM: S5PV210: Add MIPI-DSI support InKi Dae
[not found] ` <4C29B1C1.2000209@samsung.com>
[not found] ` <4C29CABE.9020208@samsung.com>
2010-07-01 22:26 ` [PATCH 1/3] FB: Add some members for CPU Interface Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701184646.0d33340c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=inki.dae@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).