linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Fri, 02 Jul 2010 07:30:01 +0000	[thread overview]
Message-ID: <20100702073001.GA25492@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTilgB3s8hy5Qg7IYpyBzwHCgK_GswVZqpxhryU5L@mail.gmail.com>

On Wed, Jun 30, 2010 at 08:02:31AM +0800, Jaya Kumar wrote:
> > diff --git a/include/linux/fb.h b/include/linux/fb.h
> > index 907ace3..73381c3 100644
> > --- a/include/linux/fb.h
> > +++ b/include/linux/fb.h
> > @@ -269,6 +269,12 @@ struct fb_var_screeninfo {
> >  	__u32 vmode;			/* see FB_VMODE_*		*/
> >  	__u32 rotate;			/* angle we rotate counter clockwise */
> >  	__u32 reserved[5];		/* Reserved for future compatibility */
> > +
> > +	/* For cpu interface timing. */
> > +	__u32 cs_setup;
> > +	__u32 wr_setup;
> > +	__u32 wr_act;
> > +	__u32 wr_hold;

This changes the framebuffer userspace API, making it incompatible with
existing users.  What this means is that stuff using the framebuffer API
in userspace has to be upgraded/downgraded in lock-step with this change
- which is not a good idea.

  parent reply	other threads:[~2010-07-02  7:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 10:49 [PATCH 1/3] FB: Add some members for CPU Interface InKi Dae
2010-06-30  0:02 ` Jaya Kumar
2010-06-30  4:36   ` InKi Dae
2010-07-01 23:47     ` Jaya Kumar
2010-07-02  1:51   ` In-Ki Dae
2010-07-02  7:30   ` Russell King - ARM Linux [this message]
2010-07-02  7:50   ` In-Ki Dae
2010-07-06 16:09     ` James Simmons
2010-07-06 15:30   ` James Simmons
2010-07-06 15:33   ` James Simmons
2010-07-06 15:35   ` James Simmons
2010-07-06 20:23   ` Geert Uytterhoeven
2010-07-07 11:37   ` James Simmons
2010-07-08  0:52   ` In-Ki Dae
2010-07-05  8:42 ` Pawel Osciak
  -- strict thread matches above, loose matches on Subject: below --
2010-07-02  1:21 In-Ki Dae
2010-07-02  1:46 ` Andrew Morton
2010-06-29  8:31 [PATCH 0/3] ARM: S5PV210: Add MIPI-DSI support InKi Dae
     [not found] ` <4C29B1C1.2000209@samsung.com>
     [not found]   ` <4C29CABE.9020208@samsung.com>
2010-07-01 22:26     ` [PATCH 1/3] FB: Add some members for CPU Interface Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702073001.GA25492@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).