From: "Ville Syrjälä" <ville.syrjala@nokia.com>
To: "ext Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Valkeinen Tomi (Nokia-MS/Helsinki)" <Tomi.Valkeinen@nokia.com>
Subject: Re: [PATCH] OMAP: DSS2: OMAPFB: add support for FBIO_WAITFORVSYNC
Date: Tue, 06 Jul 2010 10:05:33 +0000 [thread overview]
Message-ID: <20100706100533.GB8925@nokia.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044EAADA06@dbde02.ent.ti.com>
On Tue, Jul 06, 2010 at 08:08:14AM +0200, ext Hiremath, Vaibhav wrote:
> > @@ -648,6 +649,17 @@ int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd,
> > unsigned long arg)
> > r = -EFAULT;
> > break;
> >
> > + case FBIO_WAITFORVSYNC:
> > + if (get_user(p.crt, (__u32 __user *)arg)) {
> > + r = -EFAULT;
> > + break;
> > + }
> > + if (p.crt != 0) {
> > + r = -ENODEV;
> > + break;
> > + }
> > + /* FALLTHROUGH */
> > +
> > case OMAPFB_WAITFORVSYNC:
> [Hiremath, Vaibhav] I don't see any reason why we should still keep old custom IOCTL support here.
It can already be used so it should not be removed.
--
Ville Syrjälä
next prev parent reply other threads:[~2010-07-06 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 20:54 [PATCH] OMAP: DSS2: OMAPFB: add support for FBIO_WAITFORVSYNC Grazvydas Ignotas
2010-07-06 6:20 ` Hiremath, Vaibhav
2010-07-06 10:05 ` Ville Syrjälä [this message]
2010-07-06 11:38 ` Hiremath, Vaibhav
2010-07-06 11:42 ` Ville Syrjälä
2010-08-03 12:02 ` Tomi Valkeinen
2010-08-09 13:05 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706100533.GB8925@nokia.com \
--to=ville.syrjala@nokia.com \
--cc=Tomi.Valkeinen@nokia.com \
--cc=hvaibhav@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).