From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, nouveau@lists.freedesktop.org
Subject: [PATCH] vga16fb: refuse to load in face of other driver
Date: Tue, 20 Jul 2010 19:19:23 +0000 [thread overview]
Message-ID: <20100720191923.GA11056@joi.lan> (raw)
We don't want vga16fb to mess with hardware initialized by other driver.
Detect it and refuse to load.
It fixes nouveau interrupt storm on some machines.
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
---
drivers/video/vga16fb.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 28ccab4..4505446 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -22,6 +22,7 @@
#include <linux/platform_device.h>
#include <linux/screen_info.h>
+#include <asm/fb.h>
#include <asm/io.h>
#include <video/vga.h>
@@ -1415,7 +1416,7 @@ static struct platform_device *vga16fb_device;
static int __init vga16fb_init(void)
{
- int ret;
+ int ret, i;
#ifndef MODULE
char *option = NULL;
@@ -1424,6 +1425,16 @@ static int __init vga16fb_init(void)
vga16fb_setup(option);
#endif
+ for (i = 0 ; i < FB_MAX; i++) {
+ if (!registered_fb[i])
+ continue;
+ if (fb_is_primary_device(registered_fb[i])) {
+ printk(KERN_INFO "vga16fb: %s is driving the primary card, refusing to load\n",
+ registered_fb[i]->fix.id);
+ return -EBUSY;
+ }
+ }
+
ret = platform_driver_register(&vga16fb_driver);
if (!ret) {
--
1.7.1
next reply other threads:[~2010-07-20 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 19:19 Marcin Slusarz [this message]
2010-07-23 0:20 ` [PATCH] vga16fb: refuse to load in face of other driver Andrew Morton
2010-07-23 13:10 ` [PATCH v2] " Marcin Slusarz
2010-07-23 15:00 ` Geert Uytterhoeven
2010-07-25 8:42 ` [Nouveau] [PATCH v2] vga16fb: refuse to load in face of other Dave Airlie
2010-07-25 11:54 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720191923.GA11056@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).