From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [resend] cyber2000fb: fix machine hang on module load
Date: Tue, 27 Jul 2010 16:25:11 +0000 [thread overview]
Message-ID: <20100727162510.GB17099@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201007271529.22520.linux@rainbow-software.org>
On Tue, Jul 27, 2010 at 03:29:20PM +0200, Ondrej Zary wrote:
> Hello,
> I was testing two CyberPro 2000 based PCI cards on x86 and the machine always
> hanged completely when the cyber2000fb module was loaded. It seems that the
> card hangs when some registers are accessed too quickly after writing RAMDAC
> control register. With this patch, both card work.
>
> Add delay after RAMDAC control register write to prevent hangs on module load.
This one on the other hand I think is rather too heavy.
What might be better is to re-code the last register write to use
the x86 outb_p() stuff to slow it down, rather than using udelay().
Could you try something along those lines please?
next prev parent reply other threads:[~2010-07-27 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 13:29 [PATCH] [resend] cyber2000fb: fix machine hang on module load Ondrej Zary
2010-07-27 16:25 ` Russell King - ARM Linux [this message]
2010-07-27 21:18 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727162510.GB17099@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).