cyber2000fb - 24bpp and 32bpp modes not working

cyber2000fb - 24bpp and 32bpp modes not working

[Ondrej Zary]

Hello,
some more CyberPro 2000 testing shows that 24bpp and 32bpp modes don't work. 
8bpp and 16bpp modes work fine.

The mode appears to be set correctly (monitor OSD shows correct resolution and 
frequency) but console remains blank (even no cursor).

Xorg with fbdev in 24bpp mode displays mouse cursor, then gdm background and 
gdm login window and immediately segfaults. Xorg with fbdev in 32bpp mode 
works.

So the framebuffer works (24bpp crash might be Xorg bug) but maybe the console 
output is not written to the correct place?

-- 
Ondrej Zary

[PATCH] cyber2000fb: fix console in truecolor modes

[Ondrej Zary]

Return value was not set to 0 in setcolreg() with truecolor modes. This causes
fb_set_cmap() to abort after first color, resulting in blank palette - and
blank console in 24bpp and 32bpp modes.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

--- linux-2.6.35-rc3-/drivers/video/cyber2000fb.c	2010-07-29 22:27:28.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c	2010-07-29 22:29:04.000000000 +0200
@@ -392,6 +392,7 @@ cyber2000fb_setcolreg(u_int regno, u_int
 		pseudo_val |= convert_bitfield(red, &var->red);
 		pseudo_val |= convert_bitfield(green, &var->green);
 		pseudo_val |= convert_bitfield(blue, &var->blue);
+		ret = 0;
 		break;
 	}
 


-- 
Ondrej Zary