From: Ondrej Zary <linux@rainbow-software.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>,
Jean Delvare <khali@linux-fr.org>,
linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] matroxfb: fix incorrect use of memcpy_toio()
Date: Wed, 11 Aug 2010 21:16:48 +0000 [thread overview]
Message-ID: <201008112316.52063.linux@rainbow-software.org> (raw)
In-Reply-To: <20100811134136.c53f8eba.akpm@linux-foundation.org>
On Wednesday 11 August 2010 22:41:36 Andrew Morton wrote:
> On Wed, 11 Aug 2010 22:27:42 +0200
>
> Ondrej Zary <linux@rainbow-software.org> wrote:
> > Fix incorrect use of memcpy_toio() in matroxfb that broke in 2.6.34 on
> > x86.
>
> Thanks.
>
> What was incorrect about it? And what is the user-visible effect of
> this regression?
Screen is completely corrupted since 2.6.34. Bisection revealed that it's
caused by commit 6175ddf06b6172046a329e3abfd9c901a43efd2e. H. Peter Anvin
explained that memcpy_toio() does not copy data in 32bit chunks anymore on
x86.
See: http://lkml.org/lkml/2010/8/2/409
--
Ondrej Zary
prev parent reply other threads:[~2010-08-11 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 20:27 [PATCH] matroxfb: fix incorrect use of memcpy_toio() Ondrej Zary
2010-08-11 20:41 ` Andrew Morton
2010-08-11 21:16 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008112316.52063.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).