From: Colin Watson <cjwatson@canonical.com>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Jones <pjones@redhat.com>, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] Add new linearfb driver
Date: Wed, 25 Aug 2010 17:28:52 +0000 [thread overview]
Message-ID: <20100825172851.GL21862@riva.ucam.org> (raw)
In-Reply-To: <20100825190438.55ecb34d@neptune.home>
On Wed, Aug 25, 2010 at 07:04:38PM +0200, Bruno Prémont wrote:
> On Wed, 25 August 2010 Colin Watson <cjwatson@canonical.com> wrote:
> > -config FB_EFI
> > - bool "EFI-based Framebuffer Support"
> > - depends on (FB = y) && X86 && EFI
> > +config FB_LINEAR
> > + bool "Simple linear framebuffer support"
> > + depends on FB
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> ^^^^^^^^^^^^^^^^^^^^^^^
>
> > +config FB_EFI
> > + bool "EFI-based Framebuffer Support"
> > + depends on (FB = y) && X86 && EFI
> > + select FB_LINEAR
> ^^^^^^^^^^^^^^^^
> Has kconfig been adjusted to process select recursively?
> If not the selects from FB_LINEAR will have to be copied here.
When I start with a consistent .config with FB_CFB_FILLRECT unset, then
'make menuconfig' and enable FB_EFI, the resulting .config has
CONFIG_FB_CFB_FILLRECT=y. That should be a sufficient test, shouldn't
it?
Thanks,
--
Colin Watson [cjwatson@canonical.com]
next prev parent reply other threads:[~2010-08-25 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 14:11 [PATCH] Add new linearfb driver Colin Watson
2010-08-25 15:03 ` Peter Jones
2010-08-25 17:04 ` Bruno Prémont
2010-08-25 17:24 ` Peter Jones
2010-08-25 17:28 ` Colin Watson [this message]
2010-08-25 20:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825172851.GL21862@riva.ucam.org \
--to=cjwatson@canonical.com \
--cc=bonbons@linux-vserver.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).