From: Jean Delvare <khali@linux-fr.org>
To: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 11/14] drivers/video: Removing undead ifdef
Date: Tue, 07 Sep 2010 13:02:38 +0000 [thread overview]
Message-ID: <20100907150238.669778ac@hyperion.delvare> (raw)
In-Reply-To: <28eb44049d7ab968bd9c820f65595af79dee5688.1283782701.git.qy03fugy@stud.informatik.uni-erlangen.de>
On Mon, 6 Sep 2010 16:36:53 +0200, Christian Dietrich wrote:
> The CONFIG_FB_MATROX_G ifdef isn't necessary at this point, because it
> is checked in an outer ifdef level already and has no effect here.
>
> Signed-off-by: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
> ---
> drivers/video/matrox/matroxfb_DAC1064.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/matrox/matroxfb_DAC1064.c b/drivers/video/matrox/matroxfb_DAC1064.c
> index f9fa0fd..1717623 100644
> --- a/drivers/video/matrox/matroxfb_DAC1064.c
> +++ b/drivers/video/matrox/matroxfb_DAC1064.c
> @@ -869,12 +869,9 @@ static int MGAG100_preinit(struct matrox_fb_info *minfo)
> minfo->capable.plnwt = minfo->devflags.accelerator = FB_ACCEL_MATROX_MGAG100
> ? minfo->devflags.sgram : 1;
>
> -#ifdef CONFIG_FB_MATROX_G
> if (minfo->devflags.g450dac) {
> minfo->outputs[0].output = &g450out;
> - } else
> -#endif
> - {
> + } else {
> minfo->outputs[0].output = &m1064;
> }
> minfo->outputs[0].src = minfo->outputs[0].default_src;
Indeed.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
prev parent reply other threads:[~2010-09-07 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1283782698.git.qy03fugy@stud.informatik.uni-erlangen.de>
2010-09-06 14:36 ` [PATCH 11/14] drivers/video: Removing undead ifdef Christian Dietrich
2010-09-07 13:02 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907150238.669778ac@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qy03fugy@stud.informatik.uni-erlangen.de \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).